cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] dineshjoshi commented on a change in pull request #557: CASSANDRA-15753 bin/sstableverify should support user provided token ranges
Date Thu, 23 Apr 2020 04:32:56 GMT

dineshjoshi commented on a change in pull request #557:
URL: https://github.com/apache/cassandra/pull/557#discussion_r413501033



##########
File path: src/java/org/apache/cassandra/db/compaction/Verifier.java
##########
@@ -543,15 +545,17 @@ public LongPredicate getPurgeEvaluator(DecoratedKey key)
         public final boolean mutateRepairStatus;
         public final boolean checkOwnsTokens;
         public final boolean quick;
+        public final Function<String, ? extends Collection<Range<Token>>>
tokenLookup;

Review comment:
       At the very least add a comment that documents the function. Ideally, you could just
create a simple Interface/Class that can wrap this and have a meaningful method invocation
like this: `Tokens.forKeyspace(String name)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message