cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-in-jvm-dtest-api] ifesdjeen commented on pull request #10: CASSANDRA-15756 in-jvm dtest IInstance and ICoordinator should use QueryResult as the base API
Date Fri, 24 Apr 2020 16:13:33 GMT

ifesdjeen commented on pull request #10:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/10#issuecomment-619106594


   I've pushed several suggestions here (thought might be quicker this way): https://github.com/apache/cassandra-in-jvm-dtest-api/compare/master...ifesdjeen:feature/allApiUseQueryResult?expand=1
   
   Caan be summarised as:
     * should we move _classes_ to `shared` package and leave only interfaces in `api`?
     * remove `get` from some methods
     * rename `Complete` to `SImple` result
   
   I think these API changes will also help us with paged query coordinator switch in the
future!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message