cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on pull request #10: CASSANDRA-15756 in-jvm dtest IInstance and ICoordinator should use QueryResult as the base API
Date Sat, 25 Apr 2020 19:44:28 GMT

dcapwell commented on pull request #10:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/10#issuecomment-619431181


   > should we move classes to shared package and leave only interfaces in api?
   
   I don't agree with that if the class is part of the API.  The main one I see in your commit
is `Row` which to me is part of the API.  Anything a interface returns is part of the API
to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message