cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] bereng commented on a change in pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures
Date Wed, 06 May 2020 14:34:10 GMT

bereng commented on a change in pull request #570:
URL: https://github.com/apache/cassandra/pull/570#discussion_r420834322



##########
File path: src/java/org/apache/cassandra/index/Index.java
##########
@@ -136,6 +135,7 @@
  */
 public interface Index
 {
+    public static enum Loads {READS, WRITES, ALL, NONE};

Review comment:
       I think it's a personal style thing. Rather than having 2 booleans and having to reason
about them, the Enum makes it more 'in your face' imo: `ALL` is clear what it means vs 2 booleans
etc. :shrug:
   
   Also maybe I have too much imagination, but I can think of 'DELETE' as a load. You could
have 'append-only' indexes (think banking i.e.) in the future that don't support deletes.
Maybe premature optimization is being my enemy here... Or sthg with statics for custom indexes...
   
   I prefer you decide what is best here :-). I'll rename to singulars meanwhile in case we
kept that option.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message