cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] bereng commented on a change in pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures
Date Thu, 07 May 2020 07:44:22 GMT

bereng commented on a change in pull request #570:
URL: https://github.com/apache/cassandra/pull/570#discussion_r421303733



##########
File path: src/java/org/apache/cassandra/index/SecondaryIndexManager.java
##########
@@ -485,14 +471,15 @@ private void buildIndexesBlocking(Collection<SSTableReader> sstables,
Set<Index>
 
         try
         {
-            logger.info("Submitting index build of {} for data in {}",
+            logger.info("Submitting index recovery/build of {} for data in {}",
                         indexes.stream().map(i -> i.getIndexMetadata().name).collect(Collectors.joining(",")),
                         sstables.stream().map(SSTableReader::toString).collect(Collectors.joining(",")));
 
             // Group all building tasks
             Map<Index.IndexBuildingSupport, Set<Index>> byType = new HashMap<>();
             for (Index index : indexes)
             {
+                boolean isRecovery = !index.supportsLoad(Loads.ALL);

Review comment:
       This is the only contentious point imo. I don't know if we should call a `Index#isRecoveryNeeded()`
method instead rather than trying to infer it at the SIM level. The former assumes `ALL` is
mandatory for an index to the 'right', the latter allows for the index implementation to decide
that. Both make sense... It's our choice tbh and switching from one to the other in the future
it's easy enough anyway.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message