cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] smiklosovic commented on a change in pull request #555: CASSANDRA-15748 - injecting of parameters into IAuditLogger implementation
Date Thu, 07 May 2020 12:02:58 GMT

smiklosovic commented on a change in pull request #555:
URL: https://github.com/apache/cassandra/pull/555#discussion_r421450464



##########
File path: src/java/org/apache/cassandra/audit/BinAuditLogger.java
##########
@@ -40,7 +41,7 @@
 
     private volatile BinLog binLog;
 
-    public BinAuditLogger()
+    public BinAuditLogger(Map<String, String> params)

Review comment:
       @krummas please check second commit if you wish to go with that option. "other cases"
I meant e.g. `SeedProvider`, its constructor accepts this map, even empty ... `ICompressor`
implementations have static method accepting that map and so on.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message