cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-sidecar] michaelsembwever commented on a change in pull request #14: Jon/23/multiple cassandra versions
Date Thu, 14 May 2020 06:06:56 GMT

michaelsembwever commented on a change in pull request #14:
URL: https://github.com/apache/cassandra-sidecar/pull/14#discussion_r424890178



##########
File path: .circleci/config.yml
##########
@@ -100,10 +100,12 @@ jobs:
 
       - install_java:
           version: adoptopenjdk-11-hotspot
-
+      - restore_cache:
+          keys:
+            - tarballs
       - run: sudo update-java-alternatives -s adoptopenjdk-11-hotspot-amd64 && java
-version
-
-      - run: ./gradlew -i clean build --stacktrace
+      - run: mkdir ~/tarballs

Review comment:
       please can this `mkdir` be put inside gradle?
   
   In hope that CI configurations are as thin as possible, so it is as simple as possible
to repeat these steps outside of CircleCI, whether that be on locally or in https://ci-cassandra.apache.org/job/cassandra%7Esidecar/

   
   (trivial here i know, just hoping that we'll see better practices and examples with a new
project than what we have with that main project…)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message