cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-diff] krummas commented on a change in pull request #8: CASSANDRA-15807 Support running diff on multiple keyspaces
Date Mon, 18 May 2020 14:17:17 GMT

krummas commented on a change in pull request #8:
URL: https://github.com/apache/cassandra-diff/pull/8#discussion_r426645453



##########
File path: spark-job/src/test/java/org/apache/cassandra/diff/DifferTest.java
##########
@@ -74,9 +75,10 @@ public void filterTaskStatusForTables() {
         // * t2 is started and has reported some progress, but has not completed
         // * t3 has not reported any progress
         DiffJob.Split split = new DiffJob.Split(1, 1, BigInteger.ONE, BigInteger.TEN);
-        Iterable<String> tables = Lists.newArrayList("t1", "t2", "t3");
-        Function<String, DiffJob.TaskStatus> journal = (table) -> {
-            switch (table) {
+        //todo

Review comment:
       anything left here?

##########
File path: spark-job/src/main/java/org/apache/cassandra/diff/JobMetadataDb.java
##########
@@ -140,10 +142,11 @@ public static void resetStatements()
 
         /**
          *
-         * @param table
+         * @param keyspaceTablePair
          * @return
          */
-        public DiffJob.TaskStatus getLastStatus(String table) {
+        // todo

Review comment:
       anything left here?

##########
File path: spark-job/src/test/java/org/apache/cassandra/diff/DifferTest.java
##########
@@ -22,6 +22,7 @@
 import java.math.BigInteger;
 import java.util.Map;
 import java.util.function.Function;
+import java.util.stream.Collectors;

Review comment:
       unused (and there are a few old unused imports below)

##########
File path: api-server/src/main/java/org/apache/cassandra/diff/api/services/DBService.java
##########
@@ -80,8 +80,7 @@ public DBService(JobConfiguration config) {
             "   job_id," +
             "   job_start_time," +
             "   buckets," +
-            "   keyspace_name, " +
-            "   table_names, " +
+            "   keyspace_table_names, " +

Review comment:
       suggestion: we have ["qualified name"](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/QualifiedName.java)
for keyspace prefixed table names in cassandra, maybe make this `qualified_table_name`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message