cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-diff] yifan-c commented on a change in pull request #8: CASSANDRA-15807 Support running diff on multiple keyspaces
Date Mon, 18 May 2020 16:57:09 GMT

yifan-c commented on a change in pull request #8:
URL: https://github.com/apache/cassandra-diff/pull/8#discussion_r426767838



##########
File path: spark-job/src/test/java/org/apache/cassandra/diff/DifferTest.java
##########
@@ -74,9 +75,10 @@ public void filterTaskStatusForTables() {
         // * t2 is started and has reported some progress, but has not completed
         // * t3 has not reported any progress
         DiffJob.Split split = new DiffJob.Split(1, 1, BigInteger.ONE, BigInteger.TEN);
-        Iterable<String> tables = Lists.newArrayList("t1", "t2", "t3");
-        Function<String, DiffJob.TaskStatus> journal = (table) -> {
-            switch (table) {
+        //todo

Review comment:
       Forgot to remove it. The `todo` was meant to remind me to update the `tables` construction,
which was done.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message