cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] jonmeredith opened a new pull request #582: Add support for lazy NoSpamLogger argument evaluation
Date Mon, 04 May 2020 23:46:54 GMT

jonmeredith opened a new pull request #582:
URL: https://github.com/apache/cassandra/pull/582


   NoSpamLogger is use in hot logging paths.  To get the greatest benefit
   calling should be as cheap as possible.  This patch adds a variant to
   NoSpamLogger.log and friends to lazily supply the formatting parameters.
   
   It also introduces a params() helper function to make constructing the
   parameter array supplier cleaner.
   
   Fixed up existing call sites to use params where it made sense and
   altered the logging for org.apache.cassandra.net.InboundSink#accept
   so that log statements for tombstones and indices would be output
   correctly. The previous getMessage format string included info on
   keys, tables and queries that would vary between calls.
   
   Patch by Jon Meredith; reviewed by ? for CASSANDRA-15766.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message