cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrus Adamchik (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CAY-1617) removing reset functionality from EntitySorter
Date Mon, 12 Sep 2011 07:09:09 GMT

     [ https://issues.apache.org/jira/browse/CAY-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrus Adamchik updated CAY-1617:
---------------------------------

    Attachment: Archive.zip

attaching the first raw patch. as indicated in the jira, it can be done differently with no
extra factory and lazy initialization wrapper (the later almost defeats the purpose of this
Jira)

> removing reset functionality from EntitySorter
> ----------------------------------------------
>
>                 Key: CAY-1617
>                 URL: https://issues.apache.org/jira/browse/CAY-1617
>             Project: Cayenne
>          Issue Type: Task
>          Components: Core Library
>    Affects Versions: 3.1M3
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
>            Priority: Minor
>         Attachments: Archive.zip
>
>
> Another DI-inspired refactoring. Will be simplifying EntitySorter and AshwoodEntitySorter
removing reinidexing API. The sorter is assumed to be immutable and non-resettable. The patch
I am attaching to this issue introduces EntitySorterFactory. This is needed since we can't
inject EntityResolver into AshwoodEntitySorter constructor. However since DataChannel (and
its EntityResolver) do exist in DI maybe we still can avoid this extra factory and its internal
manual lazy proxy. 
> One way would be adding support for DI lazy proxies (T5-style). Another is more in line
with Cayenne DI - inject a Provider<EntitySorter> into DataDomain.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message