cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrus Adamchik (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CAY-1846) Reworking of callback mapping
Date Tue, 16 Jul 2013 19:04:50 GMT

    [ https://issues.apache.org/jira/browse/CAY-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710089#comment-13710089
] 

Andrus Adamchik edited comment on CAY-1846 at 7/16/13 7:04 PM:
---------------------------------------------------------------

The patch applied correctly. It looks a bit squashed on mac (see the screenshot). Maybe increase
the default width. Also take a look how Attributes/Relationships panels allow user to manually
change column width (which is later stored in preferences, and restored the next time you
open the modeler).

Also I am a bit reluctant to apply this piece:

Index: src/main/java/org/apache/cayenne/modeler/util/CayenneTable.java
===================================================================
--- workspace/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/CayenneTable.java
(revision 1503597)
+++ workspace/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/CayenneTable.java
(working copy)
@@ -80,9 +80,8 @@
         final DefaultCellEditor textEditor = Application
                 .getWidgetFactory()
                 .createCellEditor(textField);
-        textEditor.setClickCountToStart(1);
+        textEditor.setClickCountToStart(2);
 
-        setDefaultEditor(Object.class, textEditor);
         setDefaultEditor(String.class, textEditor);
     }
 
Not saying that what you are suggesting here is wrong, but rather that CayenneTable is used
everywhere, so this will change the behavior globally. We can discuss offline. 
                
      was (Author: andrus):
    The patch applied correctly. It looks a bit squashed on mac (see the screenshot). Maybe
increase the default width. Also take a look how Attributes/Relationships panels allow use
to manually change column width (which is later stored in preferences, and restored the next
time you open the modeler).

Also I am a bit reluctant to apply this piece:

Index: src/main/java/org/apache/cayenne/modeler/util/CayenneTable.java
===================================================================
--- workspace/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/CayenneTable.java
(revision 1503597)
+++ workspace/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/CayenneTable.java
(working copy)
@@ -80,9 +80,8 @@
         final DefaultCellEditor textEditor = Application
                 .getWidgetFactory()
                 .createCellEditor(textField);
-        textEditor.setClickCountToStart(1);
+        textEditor.setClickCountToStart(2);
 
-        setDefaultEditor(Object.class, textEditor);
         setDefaultEditor(String.class, textEditor);
     }
 
Not saying that what you are suggesting here is wrong, but rather that CayenneTable is used
everywhere, so this will change the behavior globally. We can discuss offline. 
                  
> Reworking of callback mapping
> -----------------------------
>
>                 Key: CAY-1846
>                 URL: https://issues.apache.org/jira/browse/CAY-1846
>             Project: Cayenne
>          Issue Type: Task
>          Components: Modeler
>    Affects Versions: 3.1B2
>            Reporter: Ilya Vasiuk
>            Priority: Minor
>              Labels: patch
>         Attachments: CAY-1846_after.png, CAY-1846_before.png, CAY-1846.txt, x.png
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> In this patch has been reworking callback mapping from one table to a few. And a little
bit changed the paradigm of actions with methods. Visual changes can be seen in the attached
screenshots.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message