cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrus Adamchik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAY-1846) Reworking of callback mapping
Date Wed, 17 Jul 2013 18:31:50 GMT

    [ https://issues.apache.org/jira/browse/CAY-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13711428#comment-13711428
] 

Andrus Adamchik commented on CAY-1846:
--------------------------------------

Thanks for the latest patch. It works, and I committed it to trunk. Just renamed 'CreateTable'
method to 'createTable' to follow Java method naming convention. A few improvement suggestions:

1. Callback header style change - instead of POST_LOAD, PRE_PERSIST, etc. I suggest using
PostLoad, PrePersist, etc.. This will match the names of callback annotations in Java and
hence will hopefully be more clear to the users.
2. Resizing the column works, but let's increase the initial width at least 1.5x. I.e. when
the user opens the modeler for the first time, I want him to see wider columns (you may have
to delete your local modeler preferences to test that ... IIRC those are located under ~/.java
on Linux (??))
3. Resizing behaves a bit strange - when I drag say POST_LOAD with a mouse, it expands alone,
and only when I release it, the rest of the callback panels are expanded. Can we make it expand
all together?
4. Let's replace method delete icon with a generic delete icon ("x")
5. When adding a new method under callbacks, let's make sure the added row is highlighted
(e.g. try adding an attribute or relationship - you'll see what I mean)
                
> Reworking of callback mapping
> -----------------------------
>
>                 Key: CAY-1846
>                 URL: https://issues.apache.org/jira/browse/CAY-1846
>             Project: Cayenne
>          Issue Type: Task
>          Components: Modeler
>    Affects Versions: 3.1B2
>            Reporter: Ilya Vasiuk
>            Priority: Minor
>              Labels: patch
>         Attachments: CAY-1846_after.png, CAY-1846_before.png, CAY-1846_fixed.txt, CAY-1846.txt,
x.png
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> In this patch has been reworking callback mapping from one table to a few. And a little
bit changed the paradigm of actions with methods. Visual changes can be seen in the attached
screenshots.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message