cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrus Adamchik (JIRA)" <>
Subject [jira] [Commented] (CAY-2008) Connection pool refactoring and validation query support in Cayenne DataSource
Date Thu, 30 Apr 2015 15:48:07 GMT


Andrus Adamchik commented on CAY-2008:

The actual refactoring and changes committed:

    * Refactoring and cleanup of DataSource implementation
    * DataSourceBuilder
    * splitting pool management thread into a separate DS wrapper
    * implementing java.sql.Wrapper methods
    * pool specific parameters are passed as a special object
    * stop supporting getting connections with expclicit username/password. We do not have
      notion of per-user connection pools, so it is only misleading and can lead
      to unpredictable pool state
    * validate query

> Connection pool refactoring and validation query support in Cayenne DataSource
> ------------------------------------------------------------------------------
>                 Key: CAY-2008
>                 URL:
>             Project: Cayenne
>          Issue Type: Bug
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
> While I am normally of an opinion that our own connection pool should not compete with
3rd parties, and we should instead focus on ORM features of the framework, I ran into a few
scenarios that made me reconsider and work on adding at least some features. 
> Specifically "validation query" that is run before a connection is given to the pool
user is a must have. Otherwise the user gets timed out connections. So arguably the pool is
broken as a result.
> While we are at it, we might rename connection pool classes, and provide a builder for
the pool. PoolManager is not the most intuitive name for the pooling DataSource and its construction
API is far from easy.

This message was sent by Atlassian JIRA

View raw message