cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgen...@apache.org
Subject [22/50] cayenne-modeler git commit: Fixed calling-order bug.
Date Thu, 05 Jan 2017 22:09:30 GMT
Fixed calling-order bug.


Project: http://git-wip-us.apache.org/repos/asf/cayenne-modeler/repo
Commit: http://git-wip-us.apache.org/repos/asf/cayenne-modeler/commit/c29adc7c
Tree: http://git-wip-us.apache.org/repos/asf/cayenne-modeler/tree/c29adc7c
Diff: http://git-wip-us.apache.org/repos/asf/cayenne-modeler/diff/c29adc7c

Branch: refs/heads/master
Commit: c29adc7c68a41fb176a5c4570b15e90934389a48
Parents: 97c8774
Author: mrg <blacknext@gmail.com>
Authored: Sat Oct 1 18:21:33 2016 -0400
Committer: mrg <blacknext@gmail.com>
Committed: Sat Oct 1 18:21:33 2016 -0400

----------------------------------------------------------------------
 .../java/org/apache/cayenne/modeler/layout/AbstractViewLayout.java | 2 +-
 src/main/java/org/apache/cayenne/modeler/layout/LayoutSupport.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cayenne-modeler/blob/c29adc7c/src/main/java/org/apache/cayenne/modeler/layout/AbstractViewLayout.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/cayenne/modeler/layout/AbstractViewLayout.java b/src/main/java/org/apache/cayenne/modeler/layout/AbstractViewLayout.java
index 75f5583..7e08890 100644
--- a/src/main/java/org/apache/cayenne/modeler/layout/AbstractViewLayout.java
+++ b/src/main/java/org/apache/cayenne/modeler/layout/AbstractViewLayout.java
@@ -45,7 +45,7 @@ public abstract class AbstractViewLayout
     @Deprecated // TODO: This can likely go away.
     protected void loadTab(final AnchorPane source, final AnchorPane destination)
     {
-        displayView(source, destination);
+        displayView(destination, source);
     }
 
     @Override

http://git-wip-us.apache.org/repos/asf/cayenne-modeler/blob/c29adc7c/src/main/java/org/apache/cayenne/modeler/layout/LayoutSupport.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/cayenne/modeler/layout/LayoutSupport.java b/src/main/java/org/apache/cayenne/modeler/layout/LayoutSupport.java
index 61b30c0..1d6ec48 100644
--- a/src/main/java/org/apache/cayenne/modeler/layout/LayoutSupport.java
+++ b/src/main/java/org/apache/cayenne/modeler/layout/LayoutSupport.java
@@ -62,6 +62,8 @@ public interface LayoutSupport
         // Override in subclasses to load in any necessary child layouts.
     }
 
+    // TODO: This needs a better name (method and parameters) to make clear
+    //       which is the source and which is the destination.
     default void displayView(final AnchorPane anchorPane, final Node view)
     {
         // Remove anything already there.


Mime
View raw message