cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAY-2384) Modeler: Visualization issue after an undo action for a deleted ObjRelationship
Date Fri, 01 Dec 2017 20:29:00 GMT

    [ https://issues.apache.org/jira/browse/CAY-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274931#comment-16274931
] 

ASF GitHub Bot commented on CAY-2384:
-------------------------------------

GitHub user emecas opened a pull request:

    https://github.com/apache/cayenne/pull/250

    CAY-2384  Modeler: Visualization issue after an undo action for a deleted ObjRelationship

    Added method `focusObjEntity(ObjEntity objEntity)` in `RemoveRelationshipUndoableEdit`
class, that is called during `undo()` action in order to fix CAY-2384

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/emecas/cayenne CAY-2384

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cayenne/pull/250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #250
    
----
commit 6c2d490de4920082774f01e076a63042d4292d88
Author: Emerson Castaneda <emecas@users.noreply.github.com>
Date:   2017-12-01T20:23:50Z

    Added method focusObjEntity(ObjEntity objEntity) in RemoveRelationshipUndoableEdit to
fix CAY-2384

----


> Modeler: Visualization issue after an undo action for a deleted ObjRelationship
> -------------------------------------------------------------------------------
>
>                 Key: CAY-2384
>                 URL: https://issues.apache.org/jira/browse/CAY-2384
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Modeler
>    Affects Versions: 4.1.M1
>            Reporter: Emerson Castaneda
>            Assignee: Nikita Timofeev
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 4.1.M2
>
>
> The modeler misbehaves during an undo action, it's only regarding to visualization subject.
> How to reproduce:
> Precondition: In a project with at least 2 Object Entities with ObjRelationship and ObjAttribute
in their list: ObjEntity1 and ObjEntity2  
> # go to ObjEntity1 and remove an ObjRelationship
> # switch to the ObjEntity2 to visualize its attribute(s) and relation(s)
> # go to main menu and select undo
> # the ObjAttribute list is now incorrect, the modeler only refresh the ObjRelationship
list. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message