cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ntimof...@apache.org
Subject [08/11] cayenne git commit: Code-checkers and code coverage
Date Fri, 02 Feb 2018 13:07:42 GMT
Code-checkers and code coverage


Project: http://git-wip-us.apache.org/repos/asf/cayenne/repo
Commit: http://git-wip-us.apache.org/repos/asf/cayenne/commit/97664e91
Tree: http://git-wip-us.apache.org/repos/asf/cayenne/tree/97664e91
Diff: http://git-wip-us.apache.org/repos/asf/cayenne/diff/97664e91

Branch: refs/heads/master
Commit: 97664e916f38ffe4535d8d4cefe22e06d51560cb
Parents: 0b01512
Author: Arseni Bulatski <ancarseni@gmail.com>
Authored: Fri Jan 26 15:43:44 2018 +0300
Committer: Arseni Bulatski <ancarseni@gmail.com>
Committed: Fri Jan 26 15:43:44 2018 +0300

----------------------------------------------------------------------
 .../apache/cayenne/remote/BaseConnection.java   |  2 +-
 .../reverse/configuration/ToolsModule.java      |  2 +-
 pom.xml                                         | 77 --------------------
 3 files changed, 2 insertions(+), 79 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cayenne/blob/97664e91/cayenne-client/src/main/java/org/apache/cayenne/remote/BaseConnection.java
----------------------------------------------------------------------
diff --git a/cayenne-client/src/main/java/org/apache/cayenne/remote/BaseConnection.java b/cayenne-client/src/main/java/org/apache/cayenne/remote/BaseConnection.java
index 3fdee22..b26a5a7 100644
--- a/cayenne-client/src/main/java/org/apache/cayenne/remote/BaseConnection.java
+++ b/cayenne-client/src/main/java/org/apache/cayenne/remote/BaseConnection.java
@@ -48,7 +48,7 @@ public abstract class BaseConnection implements ClientConnection {
      */
     public Object sendMessage(ClientMessage message) throws CayenneRuntimeException {
         if (message == null) {
-            throw new IllegalArgumentException("Null message");
+            throw new NullPointerException("Null message");
         }
 
         beforeSendMessage(message);

http://git-wip-us.apache.org/repos/asf/cayenne/blob/97664e91/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/configuration/ToolsModule.java
----------------------------------------------------------------------
diff --git a/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/configuration/ToolsModule.java
b/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/configuration/ToolsModule.java
index 5a96386..8e3673d 100644
--- a/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/configuration/ToolsModule.java
+++ b/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/configuration/ToolsModule.java
@@ -79,7 +79,7 @@ public class ToolsModule implements Module {
     public ToolsModule(Logger logger) {
 
         if (logger == null) {
-            throw new IllegalArgumentException("Null logger");
+            throw new NullPointerException("Null logger");
         }
 
         this.logger = logger;

http://git-wip-us.apache.org/repos/asf/cayenne/blob/97664e91/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index cf7e231..0ab5231 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1164,83 +1164,6 @@
 		</profile>
 
 
-        <profile>
-            <id>tests-development</id>
-            <activation>
-                <property>
-                    <name>tests-development</name>
-                </property>
-            </activation>
-
-            <build>
-                <plugins>
-                    <plugin>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <argLine>
-                                -DcayenneTestConnection=${cayenneTestConnection} -Djava.net.preferIPv4Stack=true
-Dcayenne.runtime.db.collation.assume.ci=${collationCi} ${surefireArgLine}
-                            </argLine>
-                        </configuration>
-                    </plugin>
-                    <plugin>
-                        <groupId>org.apache.maven.plugins</groupId>
-                        <artifactId>maven-surefire-report-plugin</artifactId>
-                        <executions>
-                            <execution>
-                                <phase>package</phase>
-                                <goals>
-                                    <goal>report-only</goal>
-                                </goals>
-                            </execution>
-                        </executions>
-                    </plugin>
-                    <plugin>
-                        <groupId>org.jacoco</groupId>
-                        <artifactId>jacoco-maven-plugin</artifactId>
-                        <version>${jacoco.version}</version>
-                        <executions>
-                            <!--
-                                Prepares the property pointing to the JaCoCo runtime agent
which
-                                is passed as VM argument when Maven the Surefire plugin is
executed.
-                            -->
-                            <execution>
-                                <id>pre-unit-test</id>
-                                <goals>
-                                    <goal>prepare-agent</goal>
-                                </goals>
-                                <configuration>
-                                    <!-- Sets the path to the file which contains the
execution data. -->
-                                    <destFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</destFile>
-                                    <!--
-                                        Sets the name of the property containing the settings
-                                        for JaCoCo runtime agent.
-                                    -->
-                                    <propertyName>surefireArgLine</propertyName>
-                                </configuration>
-                            </execution>
-                            <!--
-                                Ensures that the code coverage report for unit tests is created
after
-                                unit tests have been run.
-                            -->
-                            <execution>
-                                <id>post-unit-test</id>
-                                <phase>test</phase>
-                                <goals>
-                                    <goal>report</goal>
-                                </goals>
-                                <configuration>
-                                    <!-- Sets the path to the file which contains the
execution data. -->
-                                    <dataFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</dataFile>
-                                    <!-- Sets the output directory for the code coverage
report. -->
-                                    <outputDirectory>${project.reporting.outputDirectory}/jacoco-ut</outputDirectory>
-                                </configuration>
-                            </execution>
-                        </executions>
-                    </plugin>
-                </plugins>
-            </build>
-        </profile>
-
 		<!-- Optional profile used to sign artifacts -->
 		<profile>
 			<id>gpg</id>


Mime
View raw message