cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAY-2402) cdbimport: escape db names that is not valid Java identifiers
Date Mon, 19 Feb 2018 15:04:00 GMT

    [ https://issues.apache.org/jira/browse/CAY-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369211#comment-16369211
] 

ASF GitHub Bot commented on CAY-2402:
-------------------------------------

GitHub user aarrsseni opened a pull request:

    https://github.com/apache/cayenne/pull/273

    CAY-2402

    -Add validation to dbImport

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aarrsseni/cayenne CAY2402

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cayenne/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #273
    
----
commit 744bab0213dd3c951c62c962198ed8a53aad5339
Author: Arseni Bulatski <ancarseni@...>
Date:   2018-02-15T10:10:05Z

    CAY-2402 add validation

commit 0feef03afe360ff27e6deae1bdba5dc21b5fef47
Author: Arseni Bulatski <ancarseni@...>
Date:   2018-02-16T08:25:12Z

    Add dataMap validation to dbImportAction

----


> cdbimport: escape db names that is not valid Java identifiers
> -------------------------------------------------------------
>
>                 Key: CAY-2402
>                 URL: https://issues.apache.org/jira/browse/CAY-2402
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Non-GUI Tools
>    Affects Versions: 4.0.B2, 4.1.M1
>            Reporter: Nikita Timofeev
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 4.1.M2
>
>
> Database names starting with numbers are converted as is in Object attribute names.
> I.e. name like {{"123name"}} will end as {{<obj-attribute name="123name"/>}}.
> It can be fixed by prefixing with {{"_"}} such names.
> Also should review other special characters that can be in db names.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message