cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cayenne] faizel commented on pull request #421: Set system properties in pom.xml for maven plugin's cgen goal
Date Thu, 07 May 2020 14:39:34 GMT

faizel commented on pull request #421:
URL: https://github.com/apache/cayenne/pull/421#issuecomment-625295919


   I will defer to your judgement, but I would like to explain my case. I see that I can set
the property externally when invoking maven, but I don't seem to be able to set the property
from within the pom.xml to supply to cgen. I agree that the cayenne runtime probably should
not be messing with system properties, however I thought making the change in the maven plugin
would be okay as it is part of the build toolchain, not the runtime. When I made the change,
I tried to follow what was already done for the cgen-modeler-maven-plugin project (CayenneModelerMojo).
In any case, if you think it's not a good idea, that's also fine by me--I can live with having
to specify the argument on the command line if needed. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message