cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cayenne] faizel commented on pull request #421: Set system properties in pom.xml for maven plugin's cgen goal
Date Thu, 07 May 2020 15:48:08 GMT

faizel commented on pull request #421:
URL: https://github.com/apache/cayenne/pull/421#issuecomment-625336926


   @stariy95 @andrus The specific use case I was trying to address was for supplying a custom
velocity tool to be made available to cgen. This requires the presence of the `org.apache.velocity.tools`
system property with a value set to the path of a configuration file describing any additional
tools (can be a class path or file system path)
   
   The`CayenneGenerationAction` class will check for the existence of this property before
creating the velocity context. At the moment (and I may be wrong about this), the only way
to specify this property is via the command line when invoking maven; it is not configurable
from within the `pom.xml` file, at least not that I’ve been able to figure out.
   
   If the concern is to prevent opening up the ability to arbitrarily set system properties,
then perhaps we can specify the value of that property explicitly as a cgen configuration
parameter (e.g. `additionalToolConfig`) and have the plugin set only the required velocity
property. That way it doesn’t open up the possibility of setting arbitrary properties. 
   
   In any case, I can live with the inconvenience of specifying the command line switch if
needed. It would just be nice to be able to set it in the plugin’s configuration. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message