celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Menno van der Graaf (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CELIX-332) filter tests absent, small bugs in the source
Date Mon, 11 Jan 2016 10:30:40 GMT

     [ https://issues.apache.org/jira/browse/CELIX-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Menno van der Graaf updated CELIX-332:
    Attachment: filter_crashes_and_test.patch

Rumored leaks have been found, along with numerous segfaults.

While implementing filter_test allot of cases were found, in which a user (bundle developer)
defined string, could crash the entire framework. For example: simply forgetting to close
the filter string with the correct amount of brackets could create a segfault in some cases.

I attached a patch that adds the tests, adds sufficient error handling, and adds memory management
in the negative cases of the filter parsing (if error, clean up and return NULL)

> filter tests absent, small bugs in the source
> ---------------------------------------------
>                 Key: CELIX-332
>                 URL: https://issues.apache.org/jira/browse/CELIX-332
>             Project: Celix
>          Issue Type: Bug
>          Components: Framework
>            Reporter: Menno van der Graaf
>            Priority: Minor
>         Attachments: filter_crashes_and_test.patch
> there are no tests for "framework/filter.c".
> after a short look at the source i found some small style errors,
> there is also rumored to be a memory leak in the recursive part of the filter functions,
have not found it yet.

This message was sent by Atlassian JIRA

View raw message