celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnol...@apache.org
Subject celix git commit: CELIX-386: Removes obsolete test, which test if value of a ptr to ptr is NULL
Date Tue, 28 Mar 2017 20:04:46 GMT
Repository: celix
Updated Branches:
  refs/heads/develop 2cad0de88 -> 6072ca608


CELIX-386: Removes obsolete test, which test if value of a ptr to ptr is NULL


Project: http://git-wip-us.apache.org/repos/asf/celix/repo
Commit: http://git-wip-us.apache.org/repos/asf/celix/commit/6072ca60
Tree: http://git-wip-us.apache.org/repos/asf/celix/tree/6072ca60
Diff: http://git-wip-us.apache.org/repos/asf/celix/diff/6072ca60

Branch: refs/heads/develop
Commit: 6072ca608740ec5fbaab842831ce5f878ed48494
Parents: 2cad0de
Author: Pepijn Noltes <pepijnnoltes@gmail.com>
Authored: Tue Mar 28 22:08:46 2017 +0200
Committer: Pepijn Noltes <pepijnnoltes@gmail.com>
Committed: Tue Mar 28 22:08:46 2017 +0200

----------------------------------------------------------------------
 .../private/test/service_registration_test.cpp  | 23 --------------------
 1 file changed, 23 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/celix/blob/6072ca60/framework/private/test/service_registration_test.cpp
----------------------------------------------------------------------
diff --git a/framework/private/test/service_registration_test.cpp b/framework/private/test/service_registration_test.cpp
index 4f37c2f..916da93 100644
--- a/framework/private/test/service_registration_test.cpp
+++ b/framework/private/test/service_registration_test.cpp
@@ -348,29 +348,6 @@ TEST(service_registration, getProperties) {
 	free(name);
 }
 
-TEST(service_registration, getPropertiesIllegalArgument) {
-	registry_callback_t callback;
-	char * name = my_strdup("sevice_name");
-	service_registration_pt registration = serviceRegistration_create(callback, NULL, name,
0, NULL, NULL);
-
-	//get rid of the properties
-	properties_destroy(registration->properties);
-	registration->properties = NULL;
-
-	mock().expectOneCall("framework_logCode")
-			.withParameter("code", CELIX_ILLEGAL_ARGUMENT);
-
-	properties_pt actual = (properties_pt) 0x01;
-	celix_status_t status = serviceRegistration_getProperties(registration, &actual);
-	LONGS_EQUAL(CELIX_ILLEGAL_ARGUMENT, status);
-
-	//recreate properties to prevent segfault on serviceRegsitration_destroy
-	registration->properties = properties_create();
-
-	serviceRegistration_release(registration);
-	free(name);
-}
-
 TEST(service_registration, setProperties){
 	registry_callback_t callback;
 	callback.modified = (callback_modified_signature) serviceRegistry_servicePropertiesModified;


Mime
View raw message