From commits-return-4245-apmail-celix-commits-archive=celix.apache.org@celix.apache.org Mon Oct 16 19:01:42 2017 Return-Path: X-Original-To: apmail-celix-commits-archive@www.apache.org Delivered-To: apmail-celix-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3481F10CCE for ; Mon, 16 Oct 2017 19:01:42 +0000 (UTC) Received: (qmail 76539 invoked by uid 500); 16 Oct 2017 19:01:42 -0000 Delivered-To: apmail-celix-commits-archive@celix.apache.org Received: (qmail 76508 invoked by uid 500); 16 Oct 2017 19:01:42 -0000 Mailing-List: contact commits-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list commits@celix.apache.org Received: (qmail 76491 invoked by uid 99); 16 Oct 2017 19:01:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Oct 2017 19:01:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BD3F8DFBCA; Mon, 16 Oct 2017 19:01:39 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: pnoltes@apache.org To: commits@celix.apache.org Date: Mon, 16 Oct 2017 19:01:40 -0000 Message-Id: In-Reply-To: <8d95777442894af2a776b5f85d5d6a77@git.apache.org> References: <8d95777442894af2a776b5f85d5d6a77@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/3] celix git commit: CELIX-412: Fixes issues with perfect forwarding in the C++ depman CELIX-412: Fixes issues with perfect forwarding in the C++ depman Project: http://git-wip-us.apache.org/repos/asf/celix/repo Commit: http://git-wip-us.apache.org/repos/asf/celix/commit/b2984a4b Tree: http://git-wip-us.apache.org/repos/asf/celix/tree/b2984a4b Diff: http://git-wip-us.apache.org/repos/asf/celix/diff/b2984a4b Branch: refs/heads/develop Commit: b2984a4b37238b6e91ba3bbdc70aac940e186f76 Parents: 3514629 Author: Pepijn Noltes Authored: Mon Oct 16 21:02:52 2017 +0200 Committer: Pepijn Noltes Committed: Mon Oct 16 21:02:52 2017 +0200 ---------------------------------------------------------------------- dependency_manager_cxx/include/celix/dm/Component.h | 2 +- dependency_manager_cxx/include/celix/dm/Component_Impl.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/celix/blob/b2984a4b/dependency_manager_cxx/include/celix/dm/Component.h ---------------------------------------------------------------------- diff --git a/dependency_manager_cxx/include/celix/dm/Component.h b/dependency_manager_cxx/include/celix/dm/Component.h index 9e79d0f..06aaf20 100644 --- a/dependency_manager_cxx/include/celix/dm/Component.h +++ b/dependency_manager_cxx/include/celix/dm/Component.h @@ -127,7 +127,7 @@ namespace celix { namespace dm { * * @return the DM Component reference for chaining (fluent API) */ - Component& setInstance(T inst); + Component& setInstance(T&& inst); /** * Adds a C++ interface to provide as service to the Celix framework. http://git-wip-us.apache.org/repos/asf/celix/blob/b2984a4b/dependency_manager_cxx/include/celix/dm/Component_Impl.h ---------------------------------------------------------------------- diff --git a/dependency_manager_cxx/include/celix/dm/Component_Impl.h b/dependency_manager_cxx/include/celix/dm/Component_Impl.h index d1b1ebe..722431f 100644 --- a/dependency_manager_cxx/include/celix/dm/Component_Impl.h +++ b/dependency_manager_cxx/include/celix/dm/Component_Impl.h @@ -203,7 +203,7 @@ Component& Component::setInstance(std::unique_ptr&& inst) { } template -Component& Component::setInstance(T inst) { +Component& Component::setInstance(T&& inst) { this->instance = std::unique_ptr {nullptr}; this->sharedInstance = std::shared_ptr {nullptr}; this->valInstance.clear();