celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnol...@apache.org
Subject celix git commit: CELIX-454: Fixes some testing using concerning the mocks
Date Mon, 12 Nov 2018 08:59:22 GMT
Repository: celix
Updated Branches:
  refs/heads/feature/CELIX-454-pubsub-disc 88a575f51 -> ac47373d2


CELIX-454: Fixes some testing using concerning the mocks


Project: http://git-wip-us.apache.org/repos/asf/celix/repo
Commit: http://git-wip-us.apache.org/repos/asf/celix/commit/ac47373d
Tree: http://git-wip-us.apache.org/repos/asf/celix/tree/ac47373d
Diff: http://git-wip-us.apache.org/repos/asf/celix/diff/ac47373d

Branch: refs/heads/feature/CELIX-454-pubsub-disc
Commit: ac47373d24e20f7c1574bd50d6c709dc468330e1
Parents: 88a575f
Author: Pepijn Noltes <pepijnnoltes@gmail.com>
Authored: Mon Nov 12 09:59:01 2018 +0100
Committer: Pepijn Noltes <pepijnnoltes@gmail.com>
Committed: Mon Nov 12 09:59:01 2018 +0100

----------------------------------------------------------------------
 libs/framework/private/test/bundle_cache_test.cpp | 2 ++
 libs/framework/private/test/bundle_test.cpp       | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/celix/blob/ac47373d/libs/framework/private/test/bundle_cache_test.cpp
----------------------------------------------------------------------
diff --git a/libs/framework/private/test/bundle_cache_test.cpp b/libs/framework/private/test/bundle_cache_test.cpp
index 2c1e1c2..06cb471 100644
--- a/libs/framework/private/test/bundle_cache_test.cpp
+++ b/libs/framework/private/test/bundle_cache_test.cpp
@@ -63,6 +63,8 @@ TEST(bundle_cache, create) {
 	LONGS_EQUAL(CELIX_SUCCESS, bundleCache_create("test-uuid", configuration, &cache));
 
 	LONGS_EQUAL(CELIX_SUCCESS, bundleCache_destroy(&cache));
+
+	celix_properties_destroy(configuration);
 }
 
 TEST(bundle_cache, deleteTree) {

http://git-wip-us.apache.org/repos/asf/celix/blob/ac47373d/libs/framework/private/test/bundle_test.cpp
----------------------------------------------------------------------
diff --git a/libs/framework/private/test/bundle_test.cpp b/libs/framework/private/test/bundle_test.cpp
index e3b25e4..7d99aed 100644
--- a/libs/framework/private/test/bundle_test.cpp
+++ b/libs/framework/private/test/bundle_test.cpp
@@ -169,6 +169,7 @@ TEST(bundle, createFromArchive) {
 	POINTERS_EQUAL(framework, actual->framework);
 
 	arrayList_destroy(actual->modules);
+	free(actual->symbolicName);
 	free(actual);
 
 
@@ -879,7 +880,7 @@ TEST(bundle, refresh) {
 			.withParameter("module", module_new)
 			.andReturnValue(version);
 
-	mock().expectNCalls(2, "module_getSymbolicName")
+	mock().expectNCalls(1, "module_getSymbolicName")
 			.withParameter("module", module_new)
 			.withOutputParameterReturning("symbolicName", &symbolicName, sizeof(char*));
 


Mime
View raw message