celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnol...@apache.org
Subject [celix] branch feature/pubsub_utils_test_fix updated: Adds a missing )
Date Wed, 10 Jun 2020 19:17:25 GMT
This is an automated email from the ASF dual-hosted git repository.

pnoltes pushed a commit to branch feature/pubsub_utils_test_fix
in repository https://gitbox.apache.org/repos/asf/celix.git


The following commit(s) were added to refs/heads/feature/pubsub_utils_test_fix by this push:
     new 3616649  Adds a missing )
3616649 is described below

commit 36166496f10b0ea242e79e1a52b2dc3ffe715c33
Author: Pepijn Noltes <pepijnnoltes@gmail.com>
AuthorDate: Wed Jun 10 21:17:09 2020 +0200

    Adds a missing )
---
 .../pubsub_utils/gtest/src/PubSubSerializationProviderTestSuite.cc      | 2 +-
 bundles/pubsub/pubsub_utils/src/pubsub_serialization_provider.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bundles/pubsub/pubsub_utils/gtest/src/PubSubSerializationProviderTestSuite.cc
b/bundles/pubsub/pubsub_utils/gtest/src/PubSubSerializationProviderTestSuite.cc
index 2522bbf..db39759 100644
--- a/bundles/pubsub/pubsub_utils/gtest/src/PubSubSerializationProviderTestSuite.cc
+++ b/bundles/pubsub/pubsub_utils/gtest/src/PubSubSerializationProviderTestSuite.cc
@@ -65,7 +65,7 @@ TEST_F(PubSubSerializationProviderTestSuite, FindSerializationServices)
{
     size_t nrEntries = pubsub_serializationProvider_nrOfEntries(provider);
     EXPECT_EQ(5, nrEntries);
     size_t nrOfInvalidEntries = pubsub_serializationProvider_nrOfInvalidEntries(provider);
-    EXPECT_EQ(3, nrOfInvalidEntries); //note 4 invalid, because garbage.descriptor is never
added (cannot extract msgFqn)
+    EXPECT_EQ(3, nrOfInvalidEntries); //note 3 invalid, because garbage.descriptor is never
added (cannot extract msgFqn)
 
     auto* services = celix_bundleContext_findServices(ctx.get(), PUBSUB_MESSAGE_SERIALIZATION_SERVICE_NAME);
     EXPECT_EQ(5, celix_arrayList_size(services)); //3 valid, 5 invalid
diff --git a/bundles/pubsub/pubsub_utils/src/pubsub_serialization_provider.c b/bundles/pubsub/pubsub_utils/src/pubsub_serialization_provider.c
index 99e6d6b..02902be 100644
--- a/bundles/pubsub/pubsub_utils/src/pubsub_serialization_provider.c
+++ b/bundles/pubsub/pubsub_utils/src/pubsub_serialization_provider.c
@@ -266,7 +266,7 @@ static dyn_message_type* pubsub_serializationProvider_parseDfiDescriptor(pubsub_
 static bool pubsub_serializationProvider_alreadyAddedEntry(pubsub_serialization_provider_t*
provider, pubsub_serialization_entry_t* entry) {
     for (int i = 0; i < celix_arrayList_size(provider->serializationSvcEntries); ++i)
{
         pubsub_serialization_entry_t *visit = celix_arrayList_get(provider->serializationSvcEntries,
i);
-        if (celix_utils_stringEquals(visit->readFromEntryPath, entry->readFromEntryPath)
{
+        if (celix_utils_stringEquals(visit->readFromEntryPath, entry->readFromEntryPath))
{
             return true;
         }
     }


Mime
View raw message