chemistry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From f...@apache.org
Subject svn commit: r1517554 - in /chemistry/opencmis/trunk: ./ chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/ chemistry-opencmis-client/chemistry-opencmis-client-bindings/s...
Date Mon, 26 Aug 2013 15:15:23 GMT
Author: fmui
Date: Mon Aug 26 15:15:22 2013
New Revision: 1517554

URL: http://svn.apache.org/r1517554
Log:
code clean up and checkstyle improvements

Added:
    chemistry/opencmis/trunk/src/main/resources/suppressions.xml   (with props)
Modified:
    chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/DiscoveryServiceImpl.java
    chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/impl/SessionImpl.java
    chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/LTPAWSSecurityAuthenticationProvider.java
    chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/AtomAcl.java
    chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/HtmlDoc.java
    chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java
    chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/RepositoryService.java
    chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/AbstractBrowserServiceCall.java
    chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java
    chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/model/ClientSession.java
    chemistry/opencmis/trunk/pom.xml
    chemistry/opencmis/trunk/src/main/resources/checkstyle.xml

Modified: chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/DiscoveryServiceImpl.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/DiscoveryServiceImpl.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/DiscoveryServiceImpl.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/DiscoveryServiceImpl.java
Mon Aug 26 15:15:22 2013
@@ -35,10 +35,10 @@ import org.apache.chemistry.opencmis.com
 import org.apache.chemistry.opencmis.commons.enums.CmisVersion;
 import org.apache.chemistry.opencmis.commons.enums.IncludeRelationships;
 import org.apache.chemistry.opencmis.commons.exceptions.CmisObjectNotFoundException;
-import org.apache.chemistry.opencmis.commons.impl.XMLConverter;
-import org.apache.chemistry.opencmis.commons.impl.XMLUtils;
 import org.apache.chemistry.opencmis.commons.impl.Constants;
 import org.apache.chemistry.opencmis.commons.impl.UrlBuilder;
+import org.apache.chemistry.opencmis.commons.impl.XMLConverter;
+import org.apache.chemistry.opencmis.commons.impl.XMLUtils;
 import org.apache.chemistry.opencmis.commons.impl.dataobjects.ObjectListImpl;
 import org.apache.chemistry.opencmis.commons.impl.dataobjects.QueryTypeImpl;
 import org.apache.chemistry.opencmis.commons.spi.DiscoveryService;
@@ -146,7 +146,7 @@ public class DiscoveryServiceImpl extend
         Response resp = post(url, Constants.MEDIATYPE_QUERY, new Output() {
             public void write(OutputStream out) throws Exception {
                 XmlSerializer writer = Xml.newSerializer();
-        		writer.setOutput(out, AtomEntryWriter.ENCODING);
+                writer.setOutput(out, AtomEntryWriter.ENCODING);
                 XMLUtils.startXmlDocument(writer);
                 XMLConverter.writeQuery(writer, cmisVersion, query);
                 XMLUtils.endXmlDocument(writer);

Modified: chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/impl/SessionImpl.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/impl/SessionImpl.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/impl/SessionImpl.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/impl/SessionImpl.java
Mon Aug 26 15:15:22 2013
@@ -80,6 +80,7 @@ public class SessionImpl implements Bind
             try {
                 intValue = Integer.valueOf((String) value);
             } catch (NumberFormatException e) {
+                // invalid number -> return default value
             }
         }
 

Modified: chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/LTPAWSSecurityAuthenticationProvider.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/LTPAWSSecurityAuthenticationProvider.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/LTPAWSSecurityAuthenticationProvider.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/LTPAWSSecurityAuthenticationProvider.java
Mon Aug 26 15:15:22 2013
@@ -25,12 +25,12 @@ import java.util.Set;
 import java.util.TimeZone;
 
 import javax.security.auth.Subject;
-import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
 
 import org.apache.chemistry.opencmis.commons.exceptions.CmisRuntimeException;
 import org.apache.chemistry.opencmis.commons.impl.Base64;
 import org.apache.chemistry.opencmis.commons.impl.ClassLoaderUtil;
+import org.apache.chemistry.opencmis.commons.impl.XMLUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.w3c.dom.Document;
@@ -63,7 +63,7 @@ public class LTPAWSSecurityAuthenticatio
 
         // Create the SOAP WSSecurity header
         try {
-            Document document = DocumentBuilderFactory.newInstance().newDocumentBuilder().newDocument();
+            Document document = XMLUtils.newDomDocument();
 
             Element wsseSecurityElement = document.createElementNS(WSSE_NAMESPACE, "Security");
 

Modified: chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/AtomAcl.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/AtomAcl.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/AtomAcl.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/AtomAcl.java
Mon Aug 26 15:15:22 2013
@@ -35,7 +35,7 @@ public class AtomAcl extends AtomBase {
 
     public AtomAcl(Acl acl) {
         this();
-        setACL(acl);
+        this.acl = acl;
     }
 
     @Override

Modified: chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/HtmlDoc.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/HtmlDoc.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/HtmlDoc.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/objects/HtmlDoc.java
Mon Aug 26 15:15:22 2013
@@ -27,4 +27,4 @@ public class HtmlDoc extends AtomBase {
         return "HTML document";
     }
 
-}
+}
\ No newline at end of file

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java
Mon Aug 26 15:15:22 2013
@@ -86,7 +86,7 @@ import org.slf4j.LoggerFactory;
  */
 public class CmisAtomPubServlet extends AbstractCmisHttpServlet {
 
-    private static final Logger LOG = LoggerFactory.getLogger(CmisAtomPubServlet.class.getName());
+    private static final Logger LOG = LoggerFactory.getLogger(CmisAtomPubServlet.class);
 
     private static final long serialVersionUID = 1L;
 
@@ -318,6 +318,7 @@ public class CmisAtomPubServlet extends 
             try {
                 response.sendError(statusCode, ex.getMessage());
             } catch (Exception en) {
+                // there is nothing else we can do
             }
         }
     }

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/RepositoryService.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/RepositoryService.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/RepositoryService.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/RepositoryService.java
Mon Aug 26 15:15:22 2013
@@ -194,12 +194,16 @@ public class RepositoryService {
 
                     // - object by id
                     String url = compileUrl(baseUrl, RESOURCE_OBJECTBYID, null)
-                            + "?id={id}&filter={filter}&includeAllowableActions={includeAllowableActions}&includeACL={includeACL}&includePolicyIds={includePolicyIds}&includeRelationships={includeRelationships}&renditionFilter={renditionFilter}";
+                            + "?id={id}&filter={filter}&includeAllowableActions={includeAllowableActions}"
+                            + "&includeACL={includeACL}&includePolicyIds={includePolicyIds}"
+                            + "&includeRelationships={includeRelationships}&renditionFilter={renditionFilter}";
                     serviceDoc.writeUriTemplate(url, Constants.TEMPLATE_OBJECT_BY_ID, Constants.MEDIATYPE_ENTRY);
 
                     // - object by path
                     url = compileUrl(baseUrl, RESOURCE_OBJECTBYPATH, null)
-                            + "?path={path}&filter={filter}&includeAllowableActions={includeAllowableActions}&includeACL={includeACL}&includePolicyIds={includePolicyIds}&includeRelationships={includeRelationships}&renditionFilter={renditionFilter}";
+                            + "?path={path}&filter={filter}&includeAllowableActions={includeAllowableActions}"
+                            + "&includeACL={includeACL}&includePolicyIds={includePolicyIds}"
+                            + "&includeRelationships={includeRelationships}&renditionFilter={renditionFilter}";
                     serviceDoc.writeUriTemplate(url, Constants.TEMPLATE_OBJECT_BY_PATH, Constants.MEDIATYPE_ENTRY);
 
                     // - type by id
@@ -209,7 +213,8 @@ public class RepositoryService {
                     // - query
                     if (supportsQuery) {
                         url = compileUrl(baseUrl, RESOURCE_QUERY, null)
-                                + "?q={q}&searchAllVersions={searchAllVersions}&includeAllowableActions={includeAllowableActions}&includeRelationships={includeRelationships}&maxItems={maxItems}&skipCount={skipCount}";
+                                + "?q={q}&searchAllVersions={searchAllVersions}&includeAllowableActions={includeAllowableActions}"
+                                + "&includeRelationships={includeRelationships}&maxItems={maxItems}&skipCount={skipCount}";
                         serviceDoc.writeUriTemplate(url, Constants.TEMPLATE_QUERY, Constants.MEDIATYPE_FEED);
                     }
 

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/AbstractBrowserServiceCall.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/AbstractBrowserServiceCall.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/AbstractBrowserServiceCall.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/AbstractBrowserServiceCall.java
Mon Aug 26 15:15:22 2013
@@ -390,6 +390,8 @@ public abstract class AbstractBrowserSer
         case URI:
             propertyData = new PropertyUriImpl(propDef.getId(), strValues);
             break;
+        default:
+            assert false;
         }
 
         return propertyData;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java
Mon Aug 26 15:15:22 2013
@@ -116,7 +116,7 @@ public class CmisBrowserBindingServlet e
 
     private static final long serialVersionUID = 1L;
 
-    private static final Logger LOG = LoggerFactory.getLogger(CmisBrowserBindingServlet.class.getName());
+    private static final Logger LOG = LoggerFactory.getLogger(CmisBrowserBindingServlet.class);
 
     private final Dispatcher repositoryDispatcher = new Dispatcher(false);
     private final Dispatcher rootDispatcher = new Dispatcher(false);

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/model/ClientSession.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/model/ClientSession.java?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/model/ClientSession.java
(original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/model/ClientSession.java
Mon Aug 26 15:15:22 2013
@@ -50,9 +50,13 @@ import org.apache.chemistry.opencmis.com
 import org.apache.chemistry.opencmis.commons.enums.CapabilityAcl;
 import org.apache.chemistry.opencmis.commons.enums.IncludeRelationships;
 import org.apache.chemistry.opencmis.commons.spi.AuthenticationProvider;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class ClientSession {
 
+    private static final Logger LOG = LoggerFactory.getLogger(ClientSession.class);
+
     public static final String WORKBENCH_PREFIX = "cmis.workbench.";
     public static final String OBJECT_PREFIX = WORKBENCH_PREFIX + "object.";
     public static final String FOLDER_PREFIX = WORKBENCH_PREFIX + "folder.";
@@ -151,6 +155,7 @@ public class ClientSession {
                     CmisBindingFactory.NTLM_AUTHENTICATION_PROVIDER);
             break;
         default:
+            // no authentication
         }
 
         if (compression) {
@@ -338,6 +343,7 @@ public class ClientSession {
             sc.init(null, trustAllCerts, new java.security.SecureRandom());
             HttpsURLConnection.setDefaultSSLSocketFactory(sc.getSocketFactory());
         } catch (Exception e) {
+            LOG.error(e.getMessage(), e);
         }
     }
 }

Modified: chemistry/opencmis/trunk/pom.xml
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/pom.xml?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/pom.xml (original)
+++ chemistry/opencmis/trunk/pom.xml Mon Aug 26 15:15:22 2013
@@ -392,7 +392,8 @@
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <version>2.10</version>
                 <configuration>
-                    <configLocation>/src/main/resources/checkstyle.xml</configLocation>
+                    <configLocation>src/main/resources/checkstyle.xml</configLocation>
+                    <suppressionsLocation>src/main/resources/suppressions.xml</suppressionsLocation>
                 </configuration>
             </plugin>
             <plugin>

Modified: chemistry/opencmis/trunk/src/main/resources/checkstyle.xml
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/src/main/resources/checkstyle.xml?rev=1517554&r1=1517553&r2=1517554&view=diff
==============================================================================
--- chemistry/opencmis/trunk/src/main/resources/checkstyle.xml (original)
+++ chemistry/opencmis/trunk/src/main/resources/checkstyle.xml Mon Aug 26 15:15:22 2013
@@ -6,6 +6,10 @@
 <module name="Checker">
     <property name="charset" value="UTF-8"/>
 
+    <module name="SuppressionFilter">
+        <property name="file" value="${checkstyle.suppressions.file}"/>
+    </module>
+
     <module name="JavadocPackage">
       <property name="allowLegacy" value="true"/>
       <property name="severity" value="warning"/>
@@ -37,12 +41,15 @@
         </module>
         <module name="JavadocVariable"/>
         <module name="JavadocStyle"/>
+        <module name="MissingDeprecated"/>
+        <!--
         <module name="WriteTag">
             <property name="tag" value="@cmis"/>
             <property name="tagFormat" value="\d\.\d"/>
             <property name="severity" value="ignore"/>
             <property name="tagSeverity" value="info"/>
         </module>
+        -->
 
         <module name="ConstantName"/>
         <module name="LocalFinalVariableName"/>
@@ -75,7 +82,8 @@
         </module>    
 
         <module name="LineLength">
-            <property name="max" value="120"/>
+            <!-- the Eclipse formatter sometimes adds a few more characters: 120 ->
125 -->
+            <property name="max" value="125"/>
         </module>
         <module name="MethodLength">
             <property name="max" value="300"/>
@@ -85,8 +93,11 @@
         </module>
 
         <module name="EmptyForIteratorPad"/>
+        <module name="EmptyForInitializerPad"/>
         <module name="MethodParamPad"/>
-        <module name="NoWhitespaceAfter"/>
+        <module name="NoWhitespaceAfter">
+           <property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"/>
+        </module>
         <module name="NoWhitespaceBefore"/>
         <module name="OperatorWrap"/>
         <module name="ParenPad"/>
@@ -98,7 +109,9 @@
         <module name="RedundantModifier"/>
 
         <module name="AvoidNestedBlocks"/>
-        <module name="EmptyBlock"/>
+        <module name="EmptyBlock">
+            <property name="option" value="text"/>
+        </module>
         <module name="LeftCurly">
             <property name="option" value="eol"/>
         </module>
@@ -107,7 +120,6 @@
             <property name="option" value="same"/>
         </module>
 
-        <module name="AvoidInlineConditionals"/>
         <module name="EmptyStatement"/>
         <module name="IllegalThrows">
             <property name="severity" value="warning"/>
@@ -116,6 +128,7 @@
             <property name="severity" value="info"/>
         </module>
         <module name="EqualsHashCode"/>
+        <module name="CovariantEquals"/>
         <module name="HiddenField">
             <property name="ignoreConstructorParameter" value="true"/>
             <property name="ignoreSetter" value="true"/>

Added: chemistry/opencmis/trunk/src/main/resources/suppressions.xml
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/src/main/resources/suppressions.xml?rev=1517554&view=auto
==============================================================================
--- chemistry/opencmis/trunk/src/main/resources/suppressions.xml (added)
+++ chemistry/opencmis/trunk/src/main/resources/suppressions.xml Mon Aug 26 15:15:22 2013
@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+    "-//Puppy Crawl//DTD Suppressions 1.1//EN"
+    "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+
+<suppressions>
+    <suppress checks="Javadoc.*"
+              files="^(?!.*(org/apache/chemistry/opencmis/client/|org/apache/chemistry/opencmis/client/api/|org/apache/chemistry/opencmis/commons/|org/apache/chemistry/opencmis/server/support).*$)"/>
+    <suppress checks="Javadoc.*"
+              files=".*(/impl/.*|Impl\.java|/spi/.*|/runtime/.*)"/>
+</suppressions>
\ No newline at end of file

Propchange: chemistry/opencmis/trunk/src/main/resources/suppressions.xml
------------------------------------------------------------------------------
    svn:eol-style = native



Mime
View raw message