commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: [Fwd: [HttpClient][PATCH] Correction to addHostRequestHeader +minor formatting cleanups]
Date Thu, 11 Jul 2002 05:30:27 GMT
jsdever wrote on 07/11/2002 01:52:59 PM:

> -1 I'd suggest that Ryan re-work a couple things and submit another
> patch.
Or we can...

> rcf2616:
>    A client MUST include a Host header field in all HTTP/1.1 request
>    messages . If the requested URI does not include an Internet host
>    name for the service being requested, then the Host header field MUST
>    be given with an empty value.
> So you are saying that because an ipaddress is not an internet host
> name, the header field must be present but with an empty value.  Seems
> like a reasonable intreptation.  Can anyone confirm that?
I IP address sounds like a host name to me in the absence of 
anything else...

> While you are in the addHostRequestHeader, you might want to take care
> of that little unlabled todo comment.  The host header should only be
> sent when using HTTP/1.1 and be completely left out for HTTP/1.0.  You
> can search rfc1945 and rfc2616 for "Request Header Fields" to confirm. 
> You can use the http11 boolean variable in a conditional.
+1 to whoever gets there first.

dIon Gillard, Multitask Consulting

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message