commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <bay...@generationjava.com>
Subject Re: [lang][patch] StringUtils
Date Mon, 30 Sep 2002 00:50:29 GMT

I'd also normally be -1, but this is a pretty blatant piece of unused
code:

    else {
        char chr = strip.charAt(0);
        ... a line without chr anywhere in it ...
    }

so I've zapped it. Javadoc also fixed. All tests still pass.

Hen

On Sun, 29 Sep 2002, Steve Downey wrote:

> +1 on javadoc change
> -1 on code change, unless it fixes an actual bug. Apply it post 1.0 release.
>
> On Sunday 29 September 2002 05:02 pm, Fredrik Westermarck wrote:
> > Hi!
> >
> > Here is a patch where I have fixed a typo in javadoc and removed some
> > unused code in StringUtils.
> >
> > Regards,
> > Fredrik Westermarck
>
>
> --
> To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message