commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 22480] - [lang] Patch for javadocs
Date Sat, 16 Aug 2003 13:12:54 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22480>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22480

[lang] Patch for javadocs





------- Additional Comments From scolebourne@joda.org  2003-08-16 13:12 -------
I have applied all of the testing patch.

For the main patch, I have applied as much as I can. This includes everything 
except the builder package and StringUtils.

Unfortunately, the main patch was really too large, and contained too many 
changes. You have put a lot of work into the builder package, however I found 
some mistakes in the changes, and also a serious problem where a method was 
renamed. This shook my confidence in applying the patch.

I applied changes for CompareToBuilder manually, agreeing with some of your 
changes, disagreeing with others. This took about 2 hours for the one class, so 
I cannot procede to the others at present.

I don't want to dishearten you, as javadoc patches are very useful. For the 
future however I suggest contacting the mailing list first. I would also 
suggest separating javadoc fixes (eg.missing @param/@return) from javadoc text 
changes (better/different description) from javadoc style (html tags etc.). For 
me, each patch should take less than 30 mins (preferably 15mins) and be about 
one thing and one thing only.

thanks

Mime
View raw message