commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Kitching <si...@ecnetwork.co.nz>
Subject RE: [lang] Adding method to StringUtils (Was: Introduction)
Date Fri, 27 Feb 2004 09:58:36 GMT
On Fri, 2004-02-27 at 09:51, Gary Gregory wrote:
> Hello,
> 
> A couple of comments:
> 
> - This method might be more at home in ArrayUtils.
> - The method name should not start with a capital letter.
> - When you submit a patch, do not forget to Javadocs boundary conditions and
> special cases (null, empty arrays) and *unit tests*.

Yes, good point. The commons project (and apache's java projects in
general) make extensive use of the "JUnit" unit-testing framework.

If you don't provide junit tests with a proposal, then someone else will
have to write them for you - and as you can understand, there are not
likely to be lots of volunteers to write tests for someone else's code.
If the proposed idea is blindingly good, then perhaps...

Of course, you are probably already using junit - and if not, you should
be :-). There are plenty of examples of unit tests if you grab the
current source for any commons project.

And apache uses the standard Sun code formatting rules and naming
conventions, which you do not appear to currently be using. Though for
fairly simple methods like your initial proposal, fixing those should
not be difficult.

Regards,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message