commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Piero Ottuzzi <piero.ottu...@omnys.it>
Subject Re: [email] HtmlEmail fixes (wasRe: commons-email needs care)
Date Mon, 20 Feb 2006 13:20:56 GMT
Done.

Bye
Piero

Alle 13:12, lunedì 20 febbraio 2006, Dion Gillard ha scritto:
> This looks quite good.
>
> I'll have a look at the testing and see if we need to increase the
> testing of HtmlEmail to cover this patch.
>
> Could you add this patch to 37344?
>
> If you can't get to it in the next few days, I will:-)
>
> On 2/18/06, Piero Ottuzzi <piero.ottuzzi@omnys.it> wrote:
> > Hi Dion, all,
> >
> > I created a patch against HtmlEmail as you proposed in you comment to bug
> > 37344 (using the class provided in the same bug).
> > It fixes bugs 37159, 37178 and 37344.
> > I personally verified bug 37159 using proposed test (nice and complete
> > one..) and Mozilla Thunderbird 1.5 on Windows as email client.
> > Let me know what you think about this patch and if you like it please
> > apply.
> >
> > Bye
> > Piero
> >
> > Alle 22:56, mercoledì 15 febbraio 2006, Dion Gillard ha scritto:
> > > Tested and applied.
> > >
> > > On 2/16/06, Piero Ottuzzi <piero.ottuzzi@omnys.it> wrote:
> > > > Hi Dion, all,
> > > >
> > > > I'm still alive ;)
> > > > Attached you can find my reworked patch to fix many problems you can
> > > > have if using commons-email with a MailSession mainly caused by typos
> > > > in constant declaration or missing constant declaration. It fixes
> > > > bugs 38538 and 38656 (just opened to hold the patch): please have a
> > > > look and let me know. Probably tomorrow I will test what is in the
> > > > repository.
> > > >
> > > > Thanks for your attention
> > > > Bye
> > > > Piero
> > > >
> > > > > Ping?
> > > > >
> > > > > On 2/12/06, Dion Gillard <dion.gillard@gmail.com> wrote:
> > > > > > Hi Piero,
> > > > > >
> > > > > > some comments inline.
> > > > > >
> > > > > > On 2/9/06, Piero Ottuzzi <piero.ottuzzi@omnys.it> wrote:
> > > > > > > Hi Hen,
> > > > > > >
> > > > > > > many thanks for your answer.
> > > > > > > Here is a long mail on commons-email status :)
> > > > > > >
> > > > > > > SVN Repository
> > > > > > > The activity on SVN repository (speaking of the src/java
dir)
> > > > > > > is stalled about 5 month ago. What you can find in SVN
> > > > > > > repository compiles fine and looks like what has been released
> > > > > > > as 'Commons Email 1.0' on 2005-09-27.
> > > > > > >
> > > > > > > Bugs
> > > > > > > As you can see in [1] there are 11 bug open
> > > > > > > [37344] This bug provide a patch (in reality it provides
a
> > > > > > > whole new class). I'm using this provided class with my
patched
> > > > > > > version of commons-email and it is working fine without
any
> > > > > > > issue so far.
> > > > > >
> > > > > > The issue here is the way the patch has been implemented.
> > > > > > I'd be happier to see this implemented as a fix to HtmlEmail,
> > > > > > rather than a new class
> > > > > >
> > > > > > > [37178] Can be resolved using the new class provided in
> > > > > > > previous bug.
> > > > > >
> > > > > > See above.
> > > > > >
> > > > > > > [38538] This is fixed in my own attached patch.
> > > > > >
> > > > > > Unfortunately your patch does more than fix 38538. It adds new
> > > > > > functionality as well, and this makes it hard to apply. e.g.
> > > > > > there is code there to set the Mail Session from JNDI, which
is a
> > > > > > nice to have feature and means we now need to include the jndi
> > > > > > dependency. It would be nicer to split these into separate
> > > > > > enhancement requests as well as the bug fix.
> > > > > >
> > > > > > > [37902] Trivial ;)
> > > > > >
> > > > > > Sounds reasonable. Fixed.
> > > > > >
> > > > > > > [37783] Includes a patch. I'm using this provided patch
with my
> > > > > > > patched version of commons-email and it is working fine
without
> > > > > > > any issue so far.
> > > > > >
> > > > > > Looks reasonable. Will apply and test. Done.
> > > > > >
> > > > > > > [37782] Includes a patch which forces a new dependency
on
> > > > > > > javax.naming.* I'm using this provided patch with my patched
> > > > > > > version of commons-email and it is working fine without
any
> > > > > > > issue so far.
> > > > > >
> > > > > > it also includes the TLS authentication helpers. I'm committing
> > > > > > this one as: a) The TLS helpers are useful
> > > > > > b) jndi is in jdk1.3 and above
> > > > > >
> > > > > > > [36856] Includes patches I cannot test and I do not need
> > > > > >
> > > > > > Looks like it needs some testing.
> > > > > >
> > > > > > > [36844] Includes patches I did not test
> > > > > >
> > > > > > Introduces a dependency on commons-lang, something I'd rather
not
> > > > > > do.
> > > > > >
> > > > > > > [37363] Don't have a clue on this one.
> > > > > >
> > > > > > That one needs some more working out by the looks.
> > > > > >
> > > > > > > Patch
> > > > > > > Attached you can find a SVN patch that fixes many problems
you
> > > > > > > can see if using a MailSession that needs authentication.
It
> > > > > > > includes also the patch from bug [37782]. I'm using this
> > > > > > > provided patch with my patched version of commons-email
and it
> > > > > > > is working fine without any issue so far.
> > > > > >
> > > > > > let me know if my recent commits are working for you.
> > > > > >
> > > > > > --
> > > > > > http://www.multitask.com.au/people/dion/
> > > > > > "If I close my eyes it doesn't seem so dark." - SpongeBob
> > > > > > SquarePants
> > > > >
> > > > > --
> > > > > http://www.multitask.com.au/people/dion/
> > > > > Chuck Norris sleeps with a night light. Not because Chuck Norris
is
> > > > > afraid of the dark, but because the dark is afraid of Chuck Norris
> > >
> > > --
> > > http://www.multitask.com.au/people/dion/
> > > Chuck Norris sleeps with a night light. Not because Chuck Norris is
> > > afraid of the dark, but because the dark is afraid of Chuck Norris
> >
> > --
> > GPG KeyID: 84AE988E
> > Fingerprint: F0A0 CA2A 8D8F CC12 3F5E  C04C D8D5 9DC3 84AE 988E
> > gpg --keyserver x-hkp://search.keyserver.net:11371 --recv-key 84AE988E
>
> --
> http://www.multitask.com.au/people/dion/
> Chuck Norris sleeps with a night light. Not because Chuck Norris is
> afraid of the dark, but because the dark is afraid of Chuck Norris
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org

-- 
GPG KeyID: 84AE988E
Fingerprint: F0A0 CA2A 8D8F CC12 3F5E  C04C D8D5 9DC3 84AE 988E
gpg --keyserver x-hkp://search.keyserver.net:11371 --recv-key 84AE988E

Mime
View raw message