commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (VALIDATOR-141) PATCH - add switch to Validator.java to allow filtering out success results
Date Wed, 19 Jul 2006 13:52:17 GMT
     [ http://issues.apache.org/jira/browse/VALIDATOR-141?page=all ]

Niall Pemberton resolved VALIDATOR-141.
---------------------------------------

    Fix Version/s: 1.1.0 (alpha)
       Resolution: Fixed

Re-openned and the set to "Resolved Fixed" again to correct "resolution" which was lost in
Bugzilla --> JIRA conversion

> PATCH - add switch to Validator.java to allow filtering out success results
> ---------------------------------------------------------------------------
>
>                 Key: VALIDATOR-141
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-141
>             Project: Commons Validator
>          Issue Type: Improvement
>         Environment: Operating System: All
> Platform: All
>            Reporter: Dave Neuer
>            Priority: Minor
>             Fix For: 1.1.0 (alpha)
>
>         Attachments: filter-success.patch
>
>
> Here's a patch we have applied to our local tree to allow filtering out 
> success results (is there a use case for knowing that your input *did* pass 
> validation rules that wouldn't be better handled by trace debugging? No new is 
> good news...) 
> AFAICT, it should be perfectly binary- and source- compatible w/ existing 
> clients. 
> Please feel free to include it in the distribution. 
> There are other changes I was thinking of making as well, but thought they 
> might prove to me rather more controversial: 
> 1) In ValidatorResult, there is an unused protected member called Field -- 
> unused except by the constructor, which requires clients to pass it in even 
> though it will never be used. I don't know whether there are clients out there 
> subclassing ValidatorResult and using this, but if there are good design says 
> they should be refactored and add it to their own subclass. 
> LEGAL MUMBO-JUMBO: I have received an explicit waiver of any Nationwide 
> Appraisal Services Corp. IP rights over the software expressed in the patch 
> from Kevin Kelly, VP and MIS director of Nationwide Appraisal Services.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message