commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory" <ggreg...@seagullsoftware.com>
Subject RE: [lang] VariableFormatter - pre 2.2
Date Fri, 21 Jul 2006 15:01:47 GMT
Do you'all think the variable code be simpler to groke/reuse for
customers if there we changed the nested classes into 1st class
citizens? Kinda of a side issue I know...

G

> -----Original Message-----
> From: Henri Yandell [mailto:flamefew@gmail.com]
> Sent: Thursday, July 20, 2006 10:55 PM
> To: Jakarta Commons Developers List
> Subject: Re: [lang] VariableFormatter - pre 2.2
> 
> This is all that's left in 2.2 before an RC can be built.
> 
> On 7/5/06, Stephen Colebourne <scolebourne@btopenworld.com> wrote:
> > Henri Yandell wrote:
> > > Anyone know of any half-finished code in there at the moment?
> >
> > I think I'm on record for saying that the VariableFormatter class
> > doesn't quite fit as is IMHO. But I've not spelt out why, so here
goes...
> >
> > At a minimum, I'd like to see MapVariableResolver packge scoped.
> 
> Reading the following in the threads, no one seems to be against
> making MapVariableResolver package scoped.
> 
> Personally I don't think we should have public nested classes,
> especially if they're intended for extension. That might just be me
> being a dumb user.
> 
> VariableResolver is another public nested class (well interface). Any
> reason to not have this be package scoped for the 2.2 release as well?
> 
> > However, I thnk I'd rather see VariableResolver changed to be a more
> > general StrLookup class rather like StrMatcher. That way it could be
> > used equally as well independent of VariableFormatter.
> >
> > public class StrLookup {
> >    String lookup(String key);
> >
> >    // package scoped implementation for Map
> > }
> >
> > You could envisage other (non [lang]) accessors such as OGNL, EL,
XPath
> > or perhaps ones that accessed a List of strings by index.
> >
> > The key point is that this shouldn't be limited to just
> > VariableFormatter in the same way that StrMatcher isn't limited to
> > StrTokenizer. Separation of Concerns.
> 
> A 2.3/3.0 subject?
> 
> Hen
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message