commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne (JIRA)" <j...@apache.org>
Subject [jira] Closed: (COLLECTIONS-214) ExtendedProperties - field include should be non-static and private
Date Tue, 18 Jul 2006 22:46:16 GMT
     [ http://issues.apache.org/jira/browse/COLLECTIONS-214?page=all ]

Stephen Colebourne closed COLLECTIONS-214.
------------------------------------------

    Fix Version/s: 3.3
       Resolution: Fixed
         Assignee: Stephen Colebourne

Fixed in rv 423272

Added a private instance variable and deprecated the static variable.
Altered the get and set methods to use the instance variable falling back to the static variable
as a default.

> ExtendedProperties - field include should be non-static and private
> -------------------------------------------------------------------
>
>                 Key: COLLECTIONS-214
>                 URL: http://issues.apache.org/jira/browse/COLLECTIONS-214
>             Project: Commons Collections
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Sebb
>         Assigned To: Stephen Colebourne
>             Fix For: 3.3
>
>
> The field "include" in ExtendedProperties is currently static and protected, yet has
instance get/set accessors.
> Given that there are accessors, it seems unnecessary for the field to be protected -
it could be private.
> The field should also surely be non-static - or the accessors should be made static,
if the field really is supposed to be shared among instances.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message