commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne (JIRA)" <j...@apache.org>
Subject [jira] Closed: (COLLECTIONS-215) Javadoc in DefaultedMap very inconsistent
Date Thu, 13 Jul 2006 23:12:32 GMT
     [ http://issues.apache.org/jira/browse/COLLECTIONS-215?page=all ]
     
Stephen Colebourne closed COLLECTIONS-215:
------------------------------------------

    Fix Version: 3.3
     Resolution: Won't Fix
      Assign To: Stephen Colebourne

I can't make the changes you propose as they would be backwards incompatible. The class was
coded this way in an effort to improve performance, but that was a bad idea. But its too late
to fix now.

I have enhanced the javadoc though.

> Javadoc in DefaultedMap very inconsistent
> -----------------------------------------
>
>          Key: COLLECTIONS-215
>          URL: http://issues.apache.org/jira/browse/COLLECTIONS-215
>      Project: Commons Collections
>         Type: Improvement

>     Versions: 3.2
>     Reporter: Hendrik Maryns
>     Assignee: Stephen Colebourne
>      Fix For: 3.3
>  Attachments: DefaultedMap.diff
>
> The javadocs in DefaultedMap is very inconsistent.  It speaks
> of factory
>  when a transformer is meant, it speaks of transformer when value is
>  meant and that sort of stuff. 
>  
>  Besides, it would be much cleaner to declare 'value' of type
>  Transformer, and create a transformer every time, except when one is
>  passed (the instanceof checks are wrong anyway), (I'd rename it to
>  transformer, too). 
>  
>  Even nicer would be to split up the constructor(s) into one
>  that takes a
>  value, and one that takes a Transformer, no instanceof checks needed,
>  much cleaner code, generification is almost trivial  :-) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message