commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <>
Subject [jira] Commented: (SANDBOX-159) [finder] Make FileFilter implementations public classes in their own package.
Date Fri, 21 Jul 2006 03:58:14 GMT
    [ ] 
Henri Yandell commented on SANDBOX-159:

+1, go for it.

Looks like there are a few different types of things fixed - so commits per action would be
good if possible.

> [finder] Make FileFilter implementations public classes in their own package.
> -----------------------------------------------------------------------------
>                 Key: SANDBOX-159
>                 URL:
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Finder
>            Reporter: Niall Pemberton
>         Attachments: finder-filters-package.txt
> I'm attaching a patch which extracts the FileFilter implementations out of the FindingFilter
class into a separate "filters" package. This will allow them to be re-used in conjunction
with a new CompositeFilter.
> I've created a new CompositeFilter implementation (which FindingFilter is now based on)
which can do AND or OR processing which I think will allow quite powerful FileFilter implementations
to be created - since CompositeFilters themselves can be used as component FileFilters for
more complex CompositeFilters.
> For example to select files which are less than 1MB and have been modified in the last
20 days
>     CompositeFilter filter1 = new CompositeFilter(false, true);
>     filter1.addFilter(new SizeFilter(false, "-1m"));
>     filter1.addFilter(new TimeFilter(false, 20, false));
> As a by-product IMO it will also make creating test cases for the individual FileFilter
implementations easier.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message