commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IO-86) Add FileFinder back into Commons IO
Date Sun, 23 Jul 2006 15:08:15 GMT
    [ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422902 ] 
            
Stephen Colebourne commented on IO-86:
--------------------------------------

I've committed a more radical change to the finder. If people don't like it, then it can be
backed out.

FileFinder was suffering from doing two tasks - finding files and being a generic mechanism
for altering files. The impact of this was that the example deleter would have a public method
'find' that deleted half your filing system! Not a good thing.

I created a new abstract class DirectoryWalker which handles the generic directory walking.
FileFinder is then a specific subclass.

My problem now is that FileFinder doesn't do any more than FileUtils.listFiles(filter). So
why do we need it?

PS. DirectoryWalker could use a test class, but I'm out of time now. And my mail server is
down...

> Add FileFinder back into Commons IO
> -----------------------------------
>
>                 Key: IO-86
>                 URL: http://issues.apache.org/jira/browse/IO-86
>             Project: Commons IO
>          Issue Type: New Feature
>    Affects Versions: 1.2
>            Reporter: Niall Pemberton
>             Fix For: 1.3
>
>         Attachments: FileFinder.java, FileFinderTestCase.java, io-filefinder-start-end.patch
>
>
> I'd like to propose adding a "FileFinder" back into Commons IO. This is a simplified
version of what was recently moved out of Commons IO into the "finder" component currently
in the sandbox.
> I believe this is a simpler, more generic implementation than the finder component and
therefore would be considered suitable for inclusion in Commons IO. Although simpler it could
be used as the basis for achieving the finder component's aims - namely to emulate the unix
find command.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message