commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Holger Hoffstätte (JIRA) <j...@apache.org>
Subject [jira] Commented: (POOL-88) Better maintenance of GKOP per-pool activeCount
Date Mon, 30 Oct 2006 13:16:17 GMT
    [ http://issues.apache.org/jira/browse/POOL-88?page=comments#action_12445595 ] 
            
Holger Hoffstätte commented on POOL-88:
---------------------------------------

Some more notes:

- class ObjectQueue is not static so that inc/decActiveCount can modify the global activeCount
too.

- the only place where this lead to a bit of an odd situation was in invalidateObject(key,
obj) where I now need to explicitly fetch the ObjectQueue even in case of an error so that
the global counter can be decremented properly.

- I just saw that I erroneously marked the ObjectQueue instance variables as private, which
of course has little effect on a nonstatic inner class.


> Better maintenance of GKOP per-pool activeCount
> -----------------------------------------------
>
>                 Key: POOL-88
>                 URL: http://issues.apache.org/jira/browse/POOL-88
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: Nightly Builds
>            Reporter: Holger Hoffstätte
>            Priority: Minor
>         Attachments: activeCount.patch
>
>
> GenericKeyedObjectPool maintains a separate map for maintaining active object counts
per key. IMHO it is better to put pool metadata together with the pool (queue).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message