commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yo...@apache.org
Subject svn commit: r483576 - /jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVParser.java
Date Thu, 07 Dec 2006 18:05:01 GMT
Author: yonik
Date: Thu Dec  7 10:05:00 2006
New Revision: 483576

URL: http://svn.apache.org/viewvc?view=rev&rev=483576
Log:
[CSV] deprecated setStrategy, made most private members final

Modified:
    jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVParser.java

Modified: jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVParser.java
URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVParser.java?view=diff&rev=483576&r1=483575&r2=483576
==============================================================================
--- jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVParser.java (original)
+++ jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVParser.java Thu Dec
 7 10:05:00 2006
@@ -69,16 +69,17 @@
   private static final String[] EMPTY_STRING_ARRAY = new String[0];
    
   // the input stream
-  private ExtendedBufferedReader in;
+  private final ExtendedBufferedReader in;
 
+  // TODO: this can be made final if setStrategy is removed
   private CSVStrategy strategy;
   
   // the following objects are shared to reduce garbage 
   /** A record buffer for getLine(). Grows as necessary and is reused. */
-  private ArrayList record = new ArrayList();
-  private Token reusableToken = new Token();
-  private CharBuffer wsBuf = new CharBuffer();
-  private CharBuffer code = new CharBuffer(4);
+  private final ArrayList record = new ArrayList();
+  private final Token reusableToken = new Token();
+  private final CharBuffer wsBuf = new CharBuffer();
+  private final CharBuffer code = new CharBuffer(4);
 
   
   /**
@@ -567,6 +568,7 @@
    * Sets the specified CSV Strategy
    *
    * @return current instance of CSVParser to allow chained method calls
+   * @deprecated
    */
   public CSVParser setStrategy(CSVStrategy strategy) {
     this.strategy = strategy;



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message