commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [math] 1.2-RC2 available for review
Date Sun, 17 Feb 2008 13:45:49 GMT
On 17/02/2008, Phil Steitz <phil.steitz@gmail.com> wrote:
> Thanks, all for the feedback on RC1.  Here is another RC incorporating
> suggestions for documentation improvements, (compatible) API changes
> and sources and javadoc jars in the binary distribution.
>
> The zips / tars are here:
> http://people.apache.org/~psteitz/math-1.2-RC2/
>

The Manifest.mf files in the source and Javadoc archive jars are very basic.
It would be useful if they included most or all of the following:

Built-By: psteitz
Implementation-Title: Commons Math
Implementation-Vendor: The Apache Software Foundation
Implementation-Vendor-Id: org.apache
Implementation-Version: 1.2-RC2
Specification-Title: Commons Math
Specification-Vendor: The Apache Software Foundation
Specification-Version: 1.2-RC2

For the Javadoc jar, the following might also be relevant:

Build-Jdk: 1.5.0_12
X-Compile-Source-JDK: 1.3
X-Compile-Target-JDK: 1.3

No need to fix this now unless there are any other reasons to redo the RC.

> The site included in the binary distro is here:
> http://people.apache.org/~psteitz/math-1.2-RC2/docs/
>

The front-page says:

" Nightly builds  are built once a day from the current SVN HEAD. This
is (nearly) the lastest code and so should be treated with caution!"

Apart from the spelling mistake (lastest), I don't think the second
sentence is correct. The reason the nightly builds need to be treated
with caution is that the builds have not undergone thorough testing or
review - not that they are recent code. After all 1.2-RC2 and the
current nightly build are probably very similar (if not identical) at
present.

Since nightly builds are not approved for release, they should not be
published to everyone on the web-site, at least not in the main
section.

There aren't any nightly builds anyway at the link.

I suggest removing the Nightly Builds section from the front page; if
it is required, it should only be linked from a developer page, and
should have suitable warnings.

==

The Ant build appears to work, however the jar that is created does
not contain a LICENSE file (and the Manifest file is minimal).

==

The Maven 1 build fails:

>> Error parsing project.xml
>> ParseError at [row,col]:[216,17]
Message: Unrecognised tag: 'optional'

Rather than fix this, perhaps it would be better to remove the
M1-specific files - and instructions.

==

The M2 build seems to work OK; however the jar that is created says:

Built-By: psteitz

even though I built it. This seems to be because of the following POM line:

                <Built-By>psteitz</Built-By>

Surely, the builder id should be derived at run-time, and not from SVN?


> Release notes:
> http://people.apache.org/~psteitz/math-1.2-RC2/RELEASE-NOTES.txt
>
> Ant, Maven 1 and Maven 2 builds should all work from the unpacked
> source distribution.
 >
> Comments / suggestions for improvement welcome!
>
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message