commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <>
Subject Re: [configuration] attribute splitting WAS Re: [jira] Commented: (CONFIGURATION-335) XMLConfiguration: Can't disable attribute splitting
Date Sat, 11 Apr 2009 16:15:01 GMT

On Apr 11, 2009, at 8:26 AM, Oliver Heger wrote:

> (Maybe it's better to have this discussion on the mailing list.)
> The implementation of attributes in the experimental branch was  
> probably incomplete - the node handlers only supported single  
> attribute values, XMLConfiguration still had this splitting code.
> As I already pointed out in this ticket, the reason for the  
> implementation of attribute splitting was that the configuration API  
> allows calling addProperty() multiple times for attribute keys. So  
> an attempt was made to map those "artificial" attributes to valid  
> XML. However, looking at all the consequences of this  
> implementation, the question is whether this is really worth the  
> whole trouble.
> So I tend to disable this feature in the experimental branch. In  
> addProperty() we can check whether an attribute is to be added that  
> already exists and for instance throw a  
> ConfigurationRuntimeException in this case.
> If somebody has a better solution or other suggestions, please let  
> me know.

I'm fine with this solution.  I just needed to get all my unit tests  
to pass.

If we intentionally disable "lists" in xml attributes that makes  
perfect sense to me. At the same time we will have to go through all  
the unit tests and remove the logic that depends on attribute splitting.

I need a todo list :-)  Maybe I'll make a page on the wiki to track  
this stuff.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message