commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <GGreg...@seagullsoftware.com>
Subject RE: [Codec] Codec 1.4 RC1 available for review
Date Fri, 24 Jul 2009 01:03:33 GMT
Julius:

Do you mean it should be:

// ... convert to "\r\n"

instead of 

// ... convert to "\n"

?

Gary

> -----Original Message-----
> From: Julius Davies [mailto:juliusdavies@gmail.com]
> Sent: Wednesday, July 22, 2009 11:31 PM
> To: Commons Developers List
> Subject: Re: [Codec] Codec 1.4 RC1 available for review
> 
> ps.  Regarding CODEC-80, the javadoc and inline comment for
> testChunkedEncodeMultipleOf76() is wrong.  Sorry, I'm tired.
> 
> 
> On Wed, Jul 22, 2009 at 11:18 PM, Julius Davies<juliusdavies@gmail.com>
> wrote:
> > Hi, Niall,
> >
> > That's a nice Gaelic name you have there (my dad's name is Hywel Rhys).
> >
> > Thanks so much for RM'ing codec-1.4.  Here's some feedback for you!
> >
> >
> > Codec-1.4 will need the patches from CODEC-80 applied, since they fix
> > an annoying bug.
> >
> > I would also like to get a patch in for CODEC-59 (Add methods to
> > Base64 which work with String instead of byte[]), but I want to upload
> > a new patch.  Please ignore the one I uploaded on July 17th.  I'll
> > have my * real * patch for CODEC-59 uploaded around this time in 24
> > hours (11:00PM PDT).
> >
> > But it's not that important.  This whole CODEC-59 business can be
> > postponed for a 1.5 release, if ever.
> >
> >
> > yours,
> >
> > Julius
> >
> >
> >
> > On Wed, Jul 22, 2009 at 8:10 PM, sebb<sebbaz@gmail.com> wrote:
> >> On 23/07/2009, Niall Pemberton <niall.pemberton@gmail.com> wrote:
> >>> I have prepared a release candidate for Codec 1.4 available here:
> >>>
> >>>  http://people.apache.org/~niallp/codec-1.4-rc1/
> >>
> >> Sigs, hashes OK.
> >> N&L files look OK
> >>
> >> It's a bit confusing to have Ant, M1 and M2 build files present - are
> >> they all up to date?
> >>
> >> Builds and tests OK using M2 on Java 1.4.
> >> Did not try Ant or M1 builds.
> >>
> >>>  Site is available here:
> >>>  http://people.apache.org/~niallp/codec-1.4-rc1/site/
> >>>  (note: some links are relative and will be broken until deployed to
> >>>  proper codec home)
> >>
> >> I cannot find any reference to the minimum Java version required.
> >>
> >> JUnit could be updated to 3.8.2 (assuming Java 1.4+)
> >>
> >>>  RAT Report:
> >>>  http://people.apache.org/~niallp/codec-1.4-rc1/site/rat-report.html
> >>>
> >>>  CLIRR Report:
> >>>  http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html
> >>>
> >>>  Release Notes:
> >>>  http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html
> >>>  http://people.apache.org/~niallp/codec-1.4-rc1/RELEASE-NOTES.txt
> >>>
> >>>  Feedback welcome.
> >>>
> >>>  Niall
> >>>
> >
> >
> > --
> > yours,
> >
> > Julius Davies
> > 250-592-2284 (Home)
> > 250-893-4579 (Mobile)
> > http://juliusdavies.ca/logging.html
> >
> 
> 
> 
> --
> yours,
> 
> Julius Davies
> 250-592-2284 (Home)
> 250-893-4579 (Mobile)
> http://juliusdavies.ca/logging.html
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message