commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <>
Subject Re: [VOTE] Release math 2.2 based on RC5
Date Sat, 26 Feb 2011 16:11:36 GMT
On 2/25/11 5:15 AM, Luc Maisonobe wrote:
> Tag:
> <>
> All artifacts in Nexus staging repository:
> <>
> site:
> <>
> Clirr report:
> <>
> Votes, please. This vote will close in 72 hours, 2011-02-28T11:00:00 UTC
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
> Thanks!
> Luc
I am struggling a little on this one.  The code is good.  Builds and
tests fine. Sigs are good.  Release contents are good.  But the user
guide packaging is not as good as 2.0-2.1, IMO.  The reason that I
introduced the siteMods stuff in 2.0 was so that we could bundle
just the user guide as a self-contained set of web pages in the
binary distro.  Just file filtering from a full site build results
in broken links in the nav and the appearance of the whole site,
with only the user guide content available.  On the other hand, to
fix this, you need to do what the build script does or something
similar (at least I couldn't find a way to get it to work
otherwise), which means you can't just have maven build and deploy
the whole release without additional scripting or commands.  The nav
links in the user guide into the user guide itself work and the
links from the user guide to the bundled javadoc work, so this is
really just an appearance/useability issue.

So I guess I am +0 on this RC.  The broken links / appearance issues
are not enough for -1, or even -0, but I would rather ship the
cleaner version.  I don't know how nexus works, but I would expect
that it should be possible to generate just the binary distro and
push it out there somehow if you decide to do another RC.

> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message