commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [VOTE] Release Commons Configuration 1.7 based on RC1
Date Sun, 28 Aug 2011 19:44:10 GMT
On 8/28/11 11:53 AM, Oliver Heger wrote:
> Am 28.08.2011 20:08, schrieb Gary Gregory:
>> +1 to removing the ant build.
>>
>> Gary
>
> The ant build files were generated using the maven-ant-plugin. The
> whole stuff looks pretty complicated, and I do not like the way it
> handles dependencies either. To make it work on my local machine I
> also had to slightly modify the generated files because there was
> an issue with the OSGi manifest.
>
> Removing the ant build at all would be the easiest solution. Many
> Commons components still provide an ant build, but there are also
> examples that do not. So I am not sure how to proceed here.
>
> @Phil: Do you now have a working ant build, at least for Java 1.5?

I got it to compile the source and execute tests by removing the
"unless" from the test target.  If we decide to keep it, we should
fix the get-deps stuff.   Personally, I think its good to maintain
working Ant builds.  If you like, I can try to put together a simple
Ant build that runs tests and creates a jar.  If the consensus is to
drop it, that is fine too.  In any case, we should do something
about this.

I now see how the maven 1.4 profile excludes the classes requiring
1.5.  As you suggest, it would be good to add a note on this to the
release notes.  IIUC what is going on, the classes excluded from
compilation should also be excluded from the javadoc when built
under 1.4.  That may happen under the covers anyway, depending on
how maven prepares the source, but if not, assuming the javadoc
plugin supports excludes, they should be excluded there are well.

Phil
>
> Oliver
>
>>
>> On Aug 28, 2011, at 13:46, Phil Steitz<phil.steitz@gmail.com> 
>> wrote:
>>
>>> On 8/28/11 3:51 AM, Oliver Heger wrote:
>>>> This is a vote to release Apache Commons Configuration 1.7 based
>>>> on the first RC.
>>>>
>>>> Tag:
>>>> http://svn.apache.org/repos/asf/commons/proper/configuration/tags/CONFIGURATION_1_7RC1/
>>>>
>>>>
>>>> Distributions:
>>>> http://people.apache.org/~oheger/configuration-1.7rc1/
>>>>
>>>> Maven artifacts:
>>>> http://people.apache.org/~oheger/configuration-1.7rc1/maven/
>>>>
>>>> Site: http://people.apache.org/~oheger/configuration-1.7rc1/site/
>>>>
>>>> [ ] +1 release it
>>>> [ ] +0 go ahead I don't care
>>>> [ ] -1 no, do not release it because...
>>>>
>>>> Vote will remain open for 72 hours.
>>>
>>> The release notes (which are very nice, btw) say that 1.3 compat
>>> has
>>> been dropped, but the site says 1.4 is still supported.  I get the
>>> following compile error when I try to compile using 1.4 (under Ant)
>>> [javac] bad class file:
>>> /home/psteitz/.m2/repository/org/apache/commons/commons-vfs2/2.0/commons-vfs2-2.0.jar(org/apache/commons/vfs2/FileObject.class)
>>>
>>>     [javac] class file has wrong version 49.0, should be 48.0
>>>     [javac] Please remove or make sure it appears in the correct
>>> subdirectory of the classpath.
>>>     [javac] import org.apache.commons.vfs2.FileObject;
>>>
>>> The Ant build did not work for me out of the box either.  It should
>>> probably be either replaced with a working Ant build or
>>> removed.  It
>>> tries to pull release versions of dependencies from the apache
>>> snapshots repo and it also looks for JUNIT in ANT_HOME.  To get it
>>> to work, I removed the unless key on the test goal, and relied on
>>> the fact that all deps were already in my local repo.
>>>
>>> Other than these issues, the release looks great.  Could be the
>>> first issue is OK for runtime use, as long as whoever is using the
>>> component under 1.4 pulls in a compatible VFS if this is used.  But
>>> it looks like VFS is a required (not test only) dependency, so
>>> unless I am missing something, this means you can't build from
>>> source under 1.4.  Does the maven 1.4 profile work here?  Sorry I
>>> did not test that.
>>>
>>> Phil
>>>
>>>
>>>>
>>>> Oliver
>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>>
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>>
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message