commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Sterijevski <gsterijev...@gmail.com>
Subject Re: svn commit: r1175094 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/regression/MillerUpdatingRegression.java
Date Sat, 24 Sep 2011 15:20:26 GMT
Gilles,

You must be an android or Jedi master to spot something that tiny! ;-) Yes,
I am aware of the lowercase convention. I do intend to go through and clean
up not only that, but other ugliness in Miller... I wanted to stay as close
to the notation of the article as possible while I tested it.

Thank you,

-Greg

On Sat, Sep 24, 2011 at 4:33 AM, Gilles Sadowski <
gilles@harfang.homelinux.org> wrote:

> Hi Greg.
>
> On Sat, Sep 24, 2011 at 02:17:59AM -0000, gregs@apache.org wrote:
> > Author: gregs
> > Date: Sat Sep 24 02:17:58 2011
> > New Revision: 1175094
> >
> > URL: http://svn.apache.org/viewvc?rev=1175094&view=rev
> > Log:
> > JIRA: MATH-607 small bug in vmove method, the 'break;' directive causes
> the loop to skip the code block beginning if(!bSkip40...
> >
> > Modified:
> >
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/regression/MillerUpdatingRegression.java
> >
> > Modified:
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/regression/MillerUpdatingRegression.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/regression/MillerUpdatingRegression.java?rev=1175094&r1=1175093&r2=1175094&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/regression/MillerUpdatingRegression.java
> (original)
> > +++
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/regression/MillerUpdatingRegression.java
> Sat Sep 24 02:17:58 2011
> > @@ -771,7 +771,7 @@ public class MillerUpdatingRegression im
> >                      rhs[m] = rhs[mp1];
> >                      rhs[mp1] = X;
>
> Another Java style rule: Variables should not start with an uppercase.
>
> > [...]
>
> Regards,
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message