commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1245061 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/FastMathLiteralArrays.java
Date Thu, 23 Feb 2012 11:32:54 GMT
On 23 February 2012 11:19, Gilles Sadowski <gilles@harfang.homelinux.org> wrote:
> On Thu, Feb 23, 2012 at 10:55:51AM +0000, sebb wrote:
>> On 16 February 2012 16:17,  <luc@apache.org> wrote:
>> > Author: luc
>> > Date: Thu Feb 16 16:17:14 2012
>> > New Revision: 1245061
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1245061&view=rev
>> > Log:
>> > Removed unneeded clone.
>> >
>> > The clone did not protect the array used, only the reference ones.
>> > JIRA: MATH-650
>>
>> -1
>>
>> That was the whole point of the clone - to protect the original external data.
>
> Please (re-)explain what you mean by "protect".  Cf. my comment on the
> JIRA page.

See also your comment of 30/Nov/11 00:31.

The arrays in FastMathLiteralArrays are private, but the access
methods are not, and returning an array allows the caller to modify
array elements.

If you don't want the memory overhead of a clone, then one could use
array entry getters instead.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message