commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita" <>
Subject Re: [jcs] Request for review
Date Fri, 01 Jun 2012 04:31:48 GMT

[jcs] seems very interesting :-) and maybe I could use it in some applications too (or at
least knowing about it may help).

I'm not an expert in generics, but some time ago similar task was done in [functor], maybe
we could use that as base. I will read the changes in [functor] and will try to review the
warnings in [jcs], and then comment or propose patches.

In case you would like to take a look on what was done in [functor], check r1188373 until
r1188409 more or less. There may be more to be done in [functor] as it hasn't been released
yet, but the new version with generics is working perfectly, no broken tests, no changes in
the functionality, and I think there are no warnings. 

Hope that helps,

Bruno P. Kinoshita

> From: Thomas Vandahl <>
>To: Commons Developers List <> 
>Sent: Thursday, 31 May 2012 1:31 PM
>Subject: Re: [jcs] Request for review
>On 31.05.12 03:09, sebb wrote:
>> DoubleLinkedList looks incomplete.
>> It is parameterised by the node type (which must extend
>> DoubleLinkedListNode), but the node content type is not specified.
>> Unfortunately, I don't know how to fix this as I am no generics expert either.
>Yeah, I failed on this one, too. I decided not to silence the warnings
>so that something reminds me...
>> Eclipse generates a lot of other generics-related warnings, so it
>> could take a while to fix them.
>I know, it's work in progress. Thanks for your contributions.
>If I just were able to fix those spurious test failures.
>Bye, Thomas.
>To unsubscribe, e-mail:
>For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message