commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Duncan Jones <dun...@wortharead.com>
Subject Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations
Date Mon, 17 Sep 2012 19:26:27 GMT
On 17 September 2012 19:39, Gary Gregory <garydgregory@gmail.com> wrote:
> On Mon, Sep 17, 2012 at 2:27 PM, Matt Benson <gudnabrsam@gmail.com> wrote:
>
>> On Mon, Sep 17, 2012 at 1:19 PM, Duncan Jones <duncan@wortharead.com>
>> wrote:
>> > On 17 September 2012 19:13, Duncan Jones <duncan@wortharead.com> wrote:
>> >> On 17 September 2012 19:07, Gary Gregory <garydgregory@gmail.com>
>> wrote:
>> >>> On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson <gudnabrsam@gmail.com>
>> wrote:
>> >>>
>> >>>> Hello,
>> >>>>   We'd love to have our whole testsuite updated to JUnit 4, IMO.
 The
>> >>>> only thing is that as a rule we'd rather that changeset be separate
>> >>>> from another, so I'd recommend providing multiple patches, possibly
>> >>>> submitted in separate JIRA issues.
>> >>>>
>> >>>
>> >>> +1!
>> >>>
>> >>> Patch 1: Update to JUnit 4
>> >>> Patch 2: the patch
>> >>
>> >> No problem, I like that approach.
>> >
>> > On second thought, how would I best accomplish this? If I create a
>> > patch after converting the test case, then create another patch after
>> > fixing the issue, the latter patch will contain the changes from the
>> > first patch. Is this ok with everyone? Or is there some patch
>> > difference tool I should know about?
>> >
>>
>
> Git can help I suppose... But, I'd rather deal with these patches in two
> themes in this case, JUnit 4 and then whatever comes next. If we are going
> to spend time on JUnit 4, let's get in that mode, get it done and then move
> on to other kinds of patches.

I'm keen. I'll take a bash at a grand tidy-up over the next few days
and, if I'm successful, I'll raise a bug with a patch that brings it
all up to JUnit4.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message