commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [collections] Fix Bag interface
Date Mon, 13 May 2013 22:18:08 GMT
On 05/13/2013 09:19 PM, sebb wrote:
> On 13 May 2013 19:06, Thomas Neidhart <thomas.neidhart@gmail.com> wrote:
>> Hi,
>>
>> currently, the Bag interface states that it violates the Collection
>> contract. This is mainly because the interface was defined like that,
>> but could be easily changed.
>>
>> As we are not binary compatible anymore with previous releases, it would
>> be the right time to do this now (or leave it as it is till the end of
>> time).
>>
>> Any opinions / objections on this?
> 
> If changing the interface makes more sense, then now is the time to go for it.

ok, I have created COLLECTIONS-468 and attached a patch with the
proposed changes. Now the Bag tests can also inherit from
AbstractCollectionTest, which improves the test coverage.

Please review, and if there are no objections, I will go ahead with the
change.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message