commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1479663 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java
Date Mon, 06 May 2013 22:37:10 GMT
On 6 May 2013 23:32, Jörg Schaible <joerg.schaible@gmx.de> wrote:
>
> -1
>
> The test for this constructor showed, that you could use an own implementation
> for the last parameter. Providing a DefaultExceptionContext makes no
> difference to providing null (as it is done implicitly by the other
> constructors).
>

When fixed, this needs to be clearly documented in the test code please.

> --------------- Weitergeleitete Nachricht (Anfang)
>
> Betreff: svn commit: r1479663 -
> /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java
> Absender: britter-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org
> Datum: Mon, 06 May 2013 18:05:38 +0000
> Newsgruppe: gmane.comp.jakarta.commons.scm
>
> Author: britter
> Date: Mon May  6 18:05:37 2013
> New Revision: 1479663
>
> URL: http://svn.apache.org/r1479663
> Log:
> No need to define an anonymous subclass here
>
> Modified:
>     commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java
>
> Modified:
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java?rev=1479663&r1=1479662&r2=1479663&view=diff
> ==============================================================================
> ---
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java
> (original)
> +++
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java
> Mon May  6 18:05:37 2013
> @@ -79,7 +79,7 @@ public class ContextedRuntimeExceptionTe
>
>      @Test
>      public void testContextedExceptionStringThrowableContext() {
> -        exceptionContext = new ContextedRuntimeException(TEST_MESSAGE_2, new
> Exception(TEST_MESSAGE), new DefaultExceptionContext() {});
> +        exceptionContext = new ContextedRuntimeException(TEST_MESSAGE_2, new
> Exception(TEST_MESSAGE), new DefaultExceptionContext());
>          final String message = exceptionContext.getMessage();
>          final String trace = ExceptionUtils.getStackTrace(exceptionContext);
>          assertTrue(trace.indexOf("ContextedException")>=0);
>
>
>
> --------------- Weitergeleitete Nachricht (Ende)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message